Giter Club home page Giter Club logo

Comments (6)

DogLooksGood avatar DogLooksGood commented on August 26, 2024

Sorry, I don't have an environment to test emacs 27.1 for now.
How about upgrade to 27.2 or higher?

from meow.

Dorovich avatar Dorovich commented on August 26, 2024

Sorry, I don't have an environment to test emacs 27.1 for now. How about upgrade to 27.2 or higher?

There isn't a newer emacs package for the distribution i'm using.
I just tried compiling the latest emacs (29.1) and it works now. However, the get started section should be updated to show that the required emacs version is not ">= 27.1".

from meow.

eshrh avatar eshrh commented on August 26, 2024

i knew about this; it's why the ci on the latest commit is failing. Isn't the non-interactivity kind of just for aesthetics? In my mind being compatible with emacs 27 (this is the only syntax error i think) is more valuable than preventing the user from accidentally calling (meow-mode).

Edit, I just blamed and the CI failing was just my fault. I was the one who turned meow-esc into a minor mode in the first place, and i happened to add :interactive then. CI is passing again. However, the :interactive on meow-mode has been there for years. Why doesn't this cause an error on 27.1?

from meow.

eshrh avatar eshrh commented on August 26, 2024

Whatever the reason be, i just tested it on 27.1 and it works.

from meow.

Dorovich avatar Dorovich commented on August 26, 2024

Whatever the reason be, i just tested it on 27.1 and it works.

It worked for me when commenting out the lines with the :interactive keyword in the package source, but otherwise it would't load the package correctly (i don't know much about the way Emacs handles packages) and wouldn't work.

from meow.

eshrh avatar eshrh commented on August 26, 2024

Right, but actually the only one that needs to be commented out is in meow-esc.el, or at least on my machine.

from meow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.