RTCMTLVideoView freezes issue. about janus-videoroom-ios HOT 3 OPEN

The issue is not fixed,
but the alternative way to achieve local front camera renderer mirror effect is:

1. Update renderer rotationOverride according to the current orentation of the device；
2. Update the camera output orientation in file RTCCameraVideoCapturer,

- (void)captureOutput:(AVCaptureOutput *)captureOutput
    didOutputSampleBuffer:(CMSampleBufferRef)sampleBuffer
           fromConnection:(AVCaptureConnection *)connection
``` .

from janus-videoroom-ios.

just change to using RTCEAGLVideoView

final class WebRTCView: UIView, RTCVideoViewDelegate{
    
    var videoView = RTCEAGLVideoView(frame: .zero)
    
    var videoSize = CGSize.zero
    var isFillView = false
    
    @IBInspectable public var cornerRadius: CGFloat = 0 {
        didSet {
            layer.cornerRadius = cornerRadius
//            layer.borderWidth = cornerRadius > 0 ? 1 : 0
//            layer.borderColor = UIColor.white.cgColor
        }
    }

    override init(frame: CGRect) {
        super.init(frame: frame)
        initView()
    }

    required init?(coder: NSCoder) {
        super.init(coder: coder)
        initView()
    }
    
    func initView(){
        videoView.delegate = self
        clipsToBounds = true
        addSubview(videoView)
    }
    
    func videoView(_ videoView: RTCVideoRenderer, didChangeVideoSize size: CGSize) {
        self.videoSize = size
        setNeedsLayout()
    }

    override func layoutSubviews() {
        super.layoutSubviews()
        updateLayout()
    }
    
    func updateLayout(){
        guard videoSize.width > 0 && videoSize.height > 0 else {
            videoView.frame = bounds
            return
        }

        var videoFrame : CGRect = .zero
            
        if !isFillView{
            videoFrame = AVMakeRect(aspectRatio: videoSize, insideRect: bounds)
            let scale = videoFrame.size.aspectFitScale(in: bounds.size)
            videoFrame.size.width = videoFrame.size.width * CGFloat(scale)
            videoFrame.size.height = videoFrame.size.height * CGFloat(scale)
            
        }else{
            let newSize = aspectFill(aspectRatio: videoSize, minimumSize: bounds.size)
            videoFrame.size.width = newSize.width
            videoFrame.size.height = newSize.height
            
        }
        

        videoView.frame = videoFrame
        videoView.center = CGPoint(x: bounds.midX, y: bounds.midY)
    }
    
    func aspectFill(aspectRatio : CGSize, minimumSize: CGSize) -> CGSize {
        let mW = minimumSize.width / aspectRatio.width;
        let mH = minimumSize.height / aspectRatio.height;
        
        var temp = minimumSize
        if( mH > mW ) {
            temp.width = minimumSize.height / aspectRatio.height * aspectRatio.width;
        }
        else if( mW > mH ) {
            temp.height = minimumSize.width / aspectRatio.width * aspectRatio.height;
        }
        
        return temp;
    }
    
}


extension CGSize {
    func aspectFitScale(in container: CGSize) -> CGFloat {

        if height <= container.height && width > container.width {
            return container.width / width
        }
        if height > container.height && width > container.width {
            return min(container.width / width, container.height / height)
        }
        if height > container.height && width <= container.width {
            return container.height / height
        }
        if height <= container.height && width <= container.width {
            return min(container.width / width, container.height / height)
        }
        return 1.0
    }
}

from janus-videoroom-ios.

just change to using RTCEAGLVideoView

final class WebRTCView: UIView, RTCVideoViewDelegate{
    
    var videoView = RTCEAGLVideoView(frame: .zero)
    
    var videoSize = CGSize.zero
    var isFillView = false
    
    @IBInspectable public var cornerRadius: CGFloat = 0 {
        didSet {
            layer.cornerRadius = cornerRadius
//            layer.borderWidth = cornerRadius > 0 ? 1 : 0
//            layer.borderColor = UIColor.white.cgColor
        }
    }

    override init(frame: CGRect) {
        super.init(frame: frame)
        initView()
    }

    required init?(coder: NSCoder) {
        super.init(coder: coder)
        initView()
    }
    
    func initView(){
        videoView.delegate = self
        clipsToBounds = true
        addSubview(videoView)
    }
    
    func videoView(_ videoView: RTCVideoRenderer, didChangeVideoSize size: CGSize) {
        self.videoSize = size
        setNeedsLayout()
    }

    override func layoutSubviews() {
        super.layoutSubviews()
        updateLayout()
    }
    
    func updateLayout(){
        guard videoSize.width > 0 && videoSize.height > 0 else {
            videoView.frame = bounds
            return
        }

        var videoFrame : CGRect = .zero
            
        if !isFillView{
            videoFrame = AVMakeRect(aspectRatio: videoSize, insideRect: bounds)
            let scale = videoFrame.size.aspectFitScale(in: bounds.size)
            videoFrame.size.width = videoFrame.size.width * CGFloat(scale)
            videoFrame.size.height = videoFrame.size.height * CGFloat(scale)
            
        }else{
            let newSize = aspectFill(aspectRatio: videoSize, minimumSize: bounds.size)
            videoFrame.size.width = newSize.width
            videoFrame.size.height = newSize.height
            
        }
        

        videoView.frame = videoFrame
        videoView.center = CGPoint(x: bounds.midX, y: bounds.midY)
    }
    
    func aspectFill(aspectRatio : CGSize, minimumSize: CGSize) -> CGSize {
        let mW = minimumSize.width / aspectRatio.width;
        let mH = minimumSize.height / aspectRatio.height;
        
        var temp = minimumSize
        if( mH > mW ) {
            temp.width = minimumSize.height / aspectRatio.height * aspectRatio.width;
        }
        else if( mW > mH ) {
            temp.height = minimumSize.width / aspectRatio.width * aspectRatio.height;
        }
        
        return temp;
    }
    
}


extension CGSize {
    func aspectFitScale(in container: CGSize) -> CGFloat {

        if height <= container.height && width > container.width {
            return container.width / width
        }
        if height > container.height && width > container.width {
            return min(container.width / width, container.height / height)
        }
        if height > container.height && width <= container.width {
            return container.height / height
        }
        if height <= container.height && width <= container.width {
            return min(container.width / width, container.height / height)
        }
        return 1.0
    }
}

That's great, use RTCEAGLVideoView will work.

from janus-videoroom-ios.