Giter Club home page Giter Club logo

Comments (10)

meodai avatar meodai commented on July 29, 2024

Hey man! I know your project existed, your project is listed in the dependencies.
Great app, i gonna close the issue thought since its not really something actionable about your message. Don't hesitate to message me on twitter https://twitter.com/meodai or anywhere else basically.

from color-names.

meodai avatar meodai commented on July 29, 2024

But we can still chit chat here :D @joshuaiz I'm kinda impressed that the scroll is so smooth even though there are so many items in the dom. The HTML color export color-names is super slow...

from color-names.

joshuaiz avatar joshuaiz commented on July 29, 2024

The smooth scrolling is just css on the html element: html { scroll-behavior: smooth; } :) but the site is all React.

In the first iteration of the site, I had a page with all 17K colors and it was a bit slow to load but once all the colors were loaded, it was smooth to scroll through. I may add that page back in.

All that said, the site is faster once built than on my local install thanks to Netlify.

Also, every time you update the list, I download the json and swap out 'name' for 'n' and 'hex' for 'h' to condense it a bit and serve it locally. Since I'm doing so many color operations, I thought it would be better to do that than rely on an external file.

from color-names.

meodai avatar meodai commented on July 29, 2024

from color-names.

joshuaiz avatar joshuaiz commented on July 29, 2024

I guess I could but I save 100K by condensing the json + serving it locally and that means the site will work even offline although I have to set up the service workers.

from color-names.

meodai avatar meodai commented on July 29, 2024

from color-names.

joshuaiz avatar joshuaiz commented on July 29, 2024

That's a good idea. Still, I'm surprised at the performance as it is. On my local install, entering search is a bit slow which can happen with React apps but on the built site there is no delay at all.

I think I will add the page with all the colors - I mean why the hell not?

from color-names.

meodai avatar meodai commented on July 29, 2024

@joshuaiz something like that? https://github.com/meodai/color-names/blob/minified-json/dist/colornames.min.json removed the # to save even more space

from color-names.

joshuaiz avatar joshuaiz commented on July 29, 2024

Ooooooh that could work I think - I'd have to do a major refactor though. On the docket for v2.0. 💯

from color-names.

meodai avatar meodai commented on July 29, 2024

@joshuaiz there you go #56

from color-names.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.