Giter Club home page Giter Club logo

Comments (3)

Yiyun333 avatar Yiyun333 commented on August 17, 2024

Hi @MartijnJansenLinkit,

Thank you for your feedback!

The correct behavior should be that when Custom with rollback is triggered by an error, everything happened before the error is reverted/rolled back. Hence, the information on the New order (created and committed before the error) is also reverted and shouldn't be available anymore. Hence you also cannot create a custom log message after the error about this already non-existent new order information. I don't see anything wrong with the sentence quoted above, but I can make it a bit more informative to avoid any confusion. The Error Handling - Custom with Rollback section has more information on the whole process.

I hope that I've understood your feedback correctly. Do you have a specific case where you can show that the information created and committed before the error is still available after Custom with rollback is triggered by the error?

Best,
Yiyun

from docs.

Yiyun333 avatar Yiyun333 commented on August 17, 2024

Hi @MartijnJansenLinkit,

I've created a pull request in which I have made the sentence a bit more informative. Please let me know whether this answers your question. I will keep this issue open for another week. If I haven't received a reply then, I will merge the PR and close this issue. Thanks in advance!

Best regards,
Yiyun

from docs.

Yiyun333 avatar Yiyun333 commented on August 17, 2024

Hi @MartijnJansenLinkit,

I've merged the PR and closed this issue for now. Please let me know if you have any further feedback. Thank you!

Best regards,
Yiyun

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.