ComfyUIs python_embeded does not want to compile insightface about comfy_mtb HOT 8 CLOSED

I discovered the python-embed mode thanks to this issue!
I just tried and can reproduce! I will see how much the wheel weights and if they are not too big, I'll include them in releases, I'll do the first tag/release tomorrow probably!

from comfy_mtb.

I should probably add it to the readme!
You can use python -m pip install file.whl

from comfy_mtb.

Hi Moon Moon,

Thanks for the report, I've seen this before (python headers missing)!
From the issue you linked it seems to be a missing VS SDK on windows: https://stackoverflow.com/a/52397318/5412273
And on Linux, one must install the python3-dev!

I'm in the process of simplifying the install process too, it should be ready by tomorrow!

from comfy_mtb.

Hi @melMass and thank you for your reply!
I already installed this VS SDK and in general my locally installed python environment is fine with "building wheel for insightface". But if a call the embedded python environment
([...]python_embeded\python.exe` -m pip install -r requirements.txt)
this error still occurs.
I guess it has something to do with the embedded python environment not finding the right python3-dev files - even when they are already installed.

Thank you for taking care of this powerful ComfyUI node! I really appreciate your effort!

Kind regards

from comfy_mtb.

you can try the wheels for windows here release, you don't need to download the 135mb zip as it's just bundling a submodule that I will soon get rid off

from comfy_mtb.

Thank you @melMass,
In which folder do I have to put these whl files and is there anything I need to run afterwards?
EDIT: nevermind - I ran
C:\SD\ComfyUI_windows_portable\python_embeded\python.exe -m pip install insightface-0.7.3-cp310-cp310-win_amd64.whl
and the requirements installed successfully! Now I give your nodes a try ;-)

from comfy_mtb.

Fixed in #4 !

from comfy_mtb.

when installing the .whl files as stated above basicsr gets and error as satisfied,

python -m pip install basicsr-1.4.2-py3-none-any.whl

**Requirement already satisfied: addict in d:\2023\stable_diffusion_xl\comfyui_windows_portable\python_embeded\lib\site-packages (from basicsr==1.4.2) (2.4.0)
Collecting future (from basicsr==1.4.2)
Using cached future-0.18.3.tar.gz (840 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error

× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [6 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "C:\Users\joe\AppData\Local\Temp\pip-install-_blfa1fq\future_c67008316eb541ba85e68c2f4bfdb566\setup.py", line 86, in
import src.future
ModuleNotFoundError: No module named 'src'
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.**

but when i run comfyui it says

**### Loading: ComfyUI-Manager (V0.15.1)

ComfyUI Revision: 1211 [00da9b32]

Log level: 20
[comfy_mtb] | WARNING -> Web extensions folder at D:\2023\stable_diffusion_xl\ComfyUI_windows_portable\ComfyUI\web\extensions\mtb is not a symlink, if updating please delete it before
RestoreFace
LoadFaceEnhanceModel
[comfy_mtb] | INFO -> Some nodes failed to load:
Failed to import module faceenhance because ModuleNotFoundError: No module named 'basicsr'**

from comfy_mtb.