Giter Club home page Giter Club logo

Comments (9)

melanchall avatar melanchall commented on June 16, 2024 1

I decided to keep current signature of SendEvent. BUT it's obviously useful to have ability to get events from bytes. So I've added two classes:

  • BytesToMidiEventConverter which takes bytes array and returns MidiEvent read from the bytes;
  • MidiEventToBytesConverter which takes MidiEvent and returns byte array representing the event.

Both classes implement IDisposable so don't forget to use these classes inside using block or call Dispose manually.

So you can use BytesToMidiEventConverter to get MidiEvent and then pass that event to SendEvent method of OutputDevice.

Although it looks a bit complicated, in my opinion this way is much more flexible since it's basic. New classes can be used for different scenarios, not for MIDI events sending only, providing the same API.

New classes are in develop branch so if you want to use them right now, please build the library from sources.

from drywetmidi.

melanchall avatar melanchall commented on June 16, 2024

Hi,

Nice feature request! At now you cannot send events as bytes, but I'll definitely add this ability.

Please note that you cannot send absolutely arbitrary bytes. In MIDI standard there are two types of MIDI events you can send/receive: channel and system exclusive.

System exclusive events already can be sent as bytes:

outputDevice.SendEvent(new NormalSysExEvent(new byte[] { ... }));

So I suppose you're talking about sending channel events (line Note On or Program Change) as bytes, right?

from drywetmidi.

 avatar commented on June 16, 2024

Yes, we love using undefined MIDI commands for gaming-related applications. I personally like using control change or sysex messages that are not picked up by MIDI players to ensure backwards compatibility. Although I know others who use NoteOn events too.

from drywetmidi.

melanchall avatar melanchall commented on June 16, 2024

So why did you close the issue? :)
I'll implement sending channel events as bytes within the issue since sysex messages can be sent as bytes right now.

from drywetmidi.

 avatar commented on June 16, 2024

Thank you!

from drywetmidi.

MewsicalMiqo avatar MewsicalMiqo commented on June 16, 2024

Excellent

from drywetmidi.

melanchall avatar melanchall commented on June 16, 2024

Please give your feedback (suggestions, questions, ...) or close the issue.

from drywetmidi.

MewsicalMiqo avatar MewsicalMiqo commented on June 16, 2024

I can't close the issue anymore.

from drywetmidi.

melanchall avatar melanchall commented on June 16, 2024

@clarkx86, I received notification about your comment but unfortunately I don't see it on GitHub :( You're interested in when I'll release new version of the library including changes regarding this issue. I can't say exact date but I'll try to make release in the beginning of February.

from drywetmidi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.