Comments (3)
Oh sorry, I forgot to set Channel
property on event returned by GetProgramEvent
:
var programChangeEvent = (ProgramChangeEvent)GeneralMidiProgram.Pad8.GetProgramEvent();
programChangeEvent.Channel = (FourBitNumber)1;
chordTrackChunk.Events.Insert(0, programChangeEvent);
@meckzqz, can the issue be closed?
from drywetmidi.
Hi,
I confirm the issue. I've fixed it in develop branch and the fix will be available in next release of the library. At now you have several options to work around the issue:
-
Build the library from sources of the develop branch
-
Wait for the next release
-
Insert
ProgramChangeEvent
at start of track chunk afterToTrackChunk
call:var trackChunk = patternBuilder.Build().ToTrackChunk(TempoMap.Default, (FourBitNumber)1); trackChunk.Events.Insert(0, GeneralMidiProgram.Accordion.GetProgramEvent());
from drywetmidi.
Hello,
The quick turnaround time on this is much appreciated. I have tried using the solution you've proposed, and the results are unchanged from my previous report.
The code in question:
var trackChunk = patternBuilder.Build().ToTrackChunk(TempoMap.Default, (FourBitNumber)0);
trackChunk.Events.Insert(0, GeneralMidiProgram.Accordion.GetProgramEvent());
var chordTrackChunk = chordPatternBuilder.Build().ToTrackChunk(TempoMap.Default, (FourBitNumber)1);
chordTrackChunk.Events.Insert(0, GeneralMidiProgram.Pad8.GetProgramEvent());
MidiFile midiFile = new MidiFile(new[]
{
trackChunk,
chordTrackChunk
});
I'm prepared to switch to the develop branch for now, but I'm confused as to why this code isn't functioning as expected.
EDIT: I now realize your proposed solution understandably assumes a program change on a single TrackChunk, and likely doesn't account for this specific case.
EDIT2: Trying out the develop code now, and everything seems to be working as expected. Kudos!
from drywetmidi.
Related Issues (20)
- HELP !!! Notes in panel to midi file?? HOT 9
- please help a noob HOT 6
- Remove all notes example from the README not working HOT 9
- Using wetdrymidi in C# project causes error CS0009
- InputDevice event listening crash HOT 2
- Crash when running in Unity on M2 MacBook HOT 3
- MidiDeviceException Internal error HOT 9
- Android Support
- Unity cannot exit after use HOT 10
- MidiClock sync problem HOT 6
- MIDI Tempo changes count returns 1 but the song has 6 tempo changes. HOT 1
- add il2cpp mode HOT 5
- CustomChunk no mididata throw error HOT 4
- CSharp Code Error HOT 2
- MIDI File returns error: InvalidMetaEventParameterValueException HOT 1
- Unable to send Note-On event to device HOT 8
- Cannot get track name to change HOT 10
- How to use DryWetMidi in Visual Basic (VS 2022) ? HOT 20
- Plans for MIDI 2.0 Support? HOT 2
- Skipping notes HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drywetmidi.