Giter Club home page Giter Club logo

Comments (6)

brunoocasali avatar brunoocasali commented on June 2, 2024

Hi @jeremylynch I just stumble upon your issue.

We are using the ~> 0.26.0 so it should already allow you to update your meilisearch-ruby and meilisearch-rails version, no?

from meilisearch-rails.

ellnix avatar ellnix commented on June 2, 2024

We are using the ~> 0.26.0 so it should already allow you to update your meilisearch-ruby and meilisearch-rails version, no?

~> only allows an update to the patch version, not the minor version.

From the bundler documentation:

gem "rails", "~> 4.0.0" # which is same as gem "rails", ">= 4.0.0", "< 4.1.0" 

from meilisearch-rails.

brunoocasali avatar brunoocasali commented on June 2, 2024

Oh yeah, my bad! https://thoughtbot.com/blog/rubys-pessimistic-operator

@ellnix I'm ok if you raise the dependency to >= 0.26.0

from meilisearch-rails.

ellnix avatar ellnix commented on June 2, 2024

@ellnix I'm ok if you raise the dependency to >= 0.26.0

I think we should stick with ~> and updating the version manually. If I change the requirement to >=, someone might want to use ms-rails 0.14 as we intended it and end up with a much later of ms-ruby that may no longer be compatible.

In any case, should I PR this and also make a 0.13.1 release? (I feel like it would be better to update that on a minor version)

from meilisearch-rails.

brunoocasali avatar brunoocasali commented on June 2, 2024

In any case, should I PR this and also make a 0.13.1 release? (I feel like it would be better to update that on a minor version)

In my mind, we could always ignore the versions that are not compatible using != version or just increase the starting point, let's say meilisearch-ruby >= 0.30.0. And we always ask the users to be on the latest on both sides :D

But as you wish! I was trying to reduce the amount of work 😅

from meilisearch-rails.

jeremylynch avatar jeremylynch commented on June 2, 2024

Any update on this one?

from meilisearch-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.