Failures on test suite on a fresh clone on KeysAndPermissionsTest class about meilisearch-php HOT 9 CLOSED

yes. And I believe the issue comes with the static methods and properties we have on the test classes. When I run with Xdebug, I can see the api_key being passed to the client. And generally, I tend to avoid static methods overall. Let me try to isolate the issue in these tests.

from meilisearch-php.

It was really my issue, where I was running the docker container with wrong master-key 👎

from meilisearch-php.

Hello!
Thanks for your feedback! Glad to read you want to contribute 😁

Weird, I use php 7.4 too:

$> php -v
PHP 7.4.5 (cli) (built: Apr 18 2020 03:17:54) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.5, Copyright (c), by Zend Technologies

What do you run exactly as commands?

I ran exactly the same commands than in the README:

$ docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey --no-analytics=true
$ vendor/bin/phpunit --color tests/

from meilisearch-php.

This is what I run on the terminal.

PHPUnit 8.5.3 by Sebastian Bergmann and contributors.

.........................................FFF..................... 65 / 75 ( 86%)
..........                                                        75 / 75 (100%)

Time: 1.31 seconds, Memory: 8.00 MB

There were 3 failures:

1) KeysAndPermissionsTest::testExceptionIfNoMasterKeyProvided
Failed asserting that exception of type "MeiliSearch\Exceptions\HTTPRequestException" is thrown.

2) KeysAndPermissionsTest::testExceptionIfBadKeyProvidedToGetSettings
Failed asserting that exception of type "MeiliSearch\Exceptions\HTTPRequestException" is thrown.

3) KeysAndPermissionsTest::testExceptionIfBadKeyProvidedToGetKeys
Failed asserting that exception of type "MeiliSearch\Exceptions\HTTPRequestException" is thrown.

FAILURES!
Tests: 75, Assertions: 260, Failures: 3.

from meilisearch-php.

Just made a PR with some changes, and the CI went fine.

from meilisearch-php.

Ok! Don't know why then... 😅
Thanks a lot!

from meilisearch-php.

Closed with #13

from meilisearch-php.

Actually I have this issue is still with me. The tests are not failing on CI when I was making the PR, but it fails for me in the local.

Actually here

The request gets succeeded even if the key is not passed at all. I have downloaded the latest docker image of meilisearch and ran it.

I have PHP 7.3.13 in another system and still, 3 tests I have mentioned is failing for me.

from meilisearch-php.

Ok, sorry I didn't get you still have this issue!

Complicated to investigate it, because I do not succeed to reproduce your issue.

Are you sure you run MeiliSearch with the --master-key=masterKey locally?

from meilisearch-php.