Compatibility w/ TYPO3 v11.5-LTS about typo3-fal-quota HOT 4 CLOSED

Okay, I introduced some bugs, but they should now be fixed. Some errors remain or might be in the current version:

• event for beforeFolderCopied had a bug, which did not calculate the quota correctly (this should be a bug in the current version too), but was easily fixed
• event for beforeFileReplaced shows an exception instead of the error message, but works otherwise
• event for afterFileMoved did not update the source quota, fixed in my fork, but remains in the current version
• event for afterFolderCopied does not update the quota and I have no idea why

Some events I am not sure how to test, as they imho should not change the quota (moveFolder, rename).

I hope this is helpful

from typo3-fal-quota.

Not sure why I have not seen this issue before, but I created a fork where I switched to EventDispatcher. I mostly copied and reorganized the code. There are a few things which should probably change (e.g. the ResourceStorageException namespace) and I am open to suggestions. I only tested some basic functions, but it seems to work.

I did not change the NotifyCommand as I do not know why you are calling the Dispatcher there (I have never worked with signals and slots)

The switch from Command.php to Service.yaml should be easy as you are already using symphony commands. You need just add something like the following to the Service.yaml:

services:
  Mehrwert\FalQuota\Command\NotifyCommand:
    tags:
      - name: 'console.command'
        command: 'falquota:notifycommand'
        description: 'notify users for quota'
        hidden: false
        schedulable: true
  Mehrwert\FalQuota\Command\UpdateCommand:
    tags:
      - name: 'console.command'
        command: 'falquota:updatequota'
        description: 'update quota'
        hidden: false
        schedulable: true

The commands should now be listed as part as "Execute console command" in the scheduler

from typo3-fal-quota.

The bugs mentioned above should be fixed. From my perspective this is done and I am already using it.

Should I create a pull request or what would you prefer?

from typo3-fal-quota.

Hi @someplace53, thanks for your effort! Please feel free to create a PR.

from typo3-fal-quota.