Giter Club home page Giter Club logo

Comments (5)

dpisarewski avatar dpisarewski commented on August 16, 2024

Hi princejoseph, the bug should be fixed now. Could you please update the gem and try again?

from carrierwave-tire.

princejoseph avatar princejoseph commented on August 16, 2024

@dpisarewski yes the bug is fixed. I had actually overrided the method and wrote almost same code in the fix in an initializer to get past the error at that time.

Thanks

from carrierwave-tire.

princejoseph avatar princejoseph commented on August 16, 2024

@dpisarewski sorry, I hadnt tested the fix correctly (I had updated the gem, but I hadnt removed the initializer that I had written for the fix, so it was overriding the gem code). I tested it today again, and found the code is giving another error. I have found the issue, and has found the solution.

In lib/carrierwave/tire.rb:46

46 +            FileUtils.rm_rf File.dirname(send(column)).file.path) if send(column).file.present?

it should be

FileUtils.rm_rf File.dirname(send('#{column}')).file.path) if send('#{column}').file.present?

This is what I had written in my fix in the initializer. The send parameter should send the column name as string.

This might also work (looks more consistent with the preceding code):

FileUtils.rm_rf File.dirname(send(:#{column})).file.path) if send(:#{column}).file.present?

from carrierwave-tire.

dpisarewski avatar dpisarewski commented on August 16, 2024

Would you like to make a pull request for the fix?

from carrierwave-tire.

princejoseph avatar princejoseph commented on August 16, 2024

New to github and first open source contribution :)

from carrierwave-tire.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.