File downloaded file gets truncated in linux if calling quitAndInstall. about electron-simple-updater HOT 12 CLOSED

FIxed in v2.0.11

from electron-simple-updater.

I as I see at least in linux it is possible to rename a temporary file to an existing file to effectively achieve an atomic replacement of the old version by the new version: https://unix.stackexchange.com/questions/24395/rewrite-existing-file-so-that-it-gets-replaced-by-new-version-atomically-only-o

from electron-simple-updater.

Ok, I could figure out that currently the new version is being downloaded to the /tmp dir and then at the next quit it renames the new version to the old one and we are in business.
Regarding the issue with truncation, a workaround that seems to work is this:

  updater.on("update-downloaded", (meta: {}) => {
    logger.debug("update downloaded", meta);
    setTimeout(() => {
      updater.quitAndInstall();
    }, 5000);
  });

But it seems a bit shaky, and it should not be needed in the first place I think.

from electron-simple-updater.

Update. Seems like the workaround above does not work always, as if 5 seconds it is not enough for the whole file to be downloaded, it almost seems as if the event update-downladed is actually triggered before the whole file is downloaded :/

from electron-simple-updater.

Thanks for the information, I'll review again the downloader code on this week.

from electron-simple-updater.

Actually I think the issue comes from the httpreq package:
https://github.com/SamDecrock/node-httpreq/blob/c2dbc959ea8538ffcbb12c5a7e7e1b90abd7d5e0/lib/httpreq.js#L330
It is listening to res.on('end') to decide the file has been downloaded and stored to disk, however it should be listening to the "target" stream instead, downloadStream.on('end'). Examining a bit more the quality of the httpreq code and the pretty low stars rate I would seriously consider to replace this library by something more battle tested and popular such as "request" or "node-fetch".

from electron-simple-updater.

In fact it should not even be listening to the "end" event but to the "finish" event. So a working code for download a file would be more in this style:

async function download() {
  const res = await fetch(srcFileUrl)
  await new Promise((resolve, reject) => {
    const fileStream = fs.createWriteStream(destinationPath);
    res.body.pipe(fileStream);
    res.body.on("error", (err) => {
      reject(err);
    });
    fileStream.on("finish", function() {
      resolve();
    });
  });
}

from electron-simple-updater.

https://stackoverflow.com/questions/28334610/whats-the-difference-between-end-and-finish-events-in-node-streams

from electron-simple-updater.

Actually I think the issue I reporting here is the same as this one: #58

The reason why the poster of #58 got it working is because he implemented downloadFile correctly.

from electron-simple-updater.

Thank you very much for details. Yes, I'm thinking about migrating to axios. Unfortunately, I have no time at this moment to dive into the issue, will try to do that in the beginning of the next week, maybe earlier.

from electron-simple-updater.

Since this issue was a show stopper for me I ended up using the standard electron-updater which actually works really well. Just in case somebody else encounters this issue thats the workaround I found.

from electron-simple-updater.

Sorry, sometimes I absolutely have no time for opensource. Anyway, I still have plans to make a release on the week.

from electron-simple-updater.