Giter Club home page Giter Club logo

Comments (7)

megahertz avatar megahertz commented on August 25, 2024

Because sometimes it's used without electron (with NW.js for example).

from electron-log.

develar avatar develar commented on August 25, 2024

Let's just check electron/electron#2288 (comment) ;)?

from electron-log.

megahertz avatar megahertz commented on August 25, 2024

Thanks for the information, I forgot about that. But there is one problem - how to require electron and don't break a non-electron project which uses webpack.

from electron-log.

develar avatar develar commented on August 25, 2024

require only after check that it is electron. require is not restricted to be only on top file level. For ES6 as well (as yarn or electron-builder uses https://github.com/zertosh/babel-plugin-transform-inline-imports-commonjs).

from electron-log.

megahertz avatar megahertz commented on August 25, 2024

I thinked before that webpack/babel doesn't care whether require is called on a top level or not. Thanks for the idea, I'll check it later.

from electron-log.

develar avatar develar commented on August 25, 2024

Thank you for amazing module without tons of questionable dependencies :) This module will be recommended by electron-builder to debug auto-updater.

from electron-log.

megahertz avatar megahertz commented on August 25, 2024

Now it uses app.getName

from electron-log.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.