Comments (6)
You also will need to enable dom.getRootNode.enabled. :) Then it will work for you.
I did not knew about waterfox browser, I will add this too in addons page and in github also so that future users of this extension does not face problem when using waterfox browser. :)
from dictionary-anywhere.
Thanks! Works as expected now.
I'd also recommend adding a bit on what these two settings do and why they need to be changed. I've used lots of add-ons and don't recall ever having to change anything in about:config for them to work, including when using ones that generate pop-ups like this one does, so I wonder if there's a better way to achieve whatever is needed that requires them to be changed and I'd like to know what's happening when I change them so I know I'm not reducing security or functionality in some way.
from dictionary-anywhere.
I use shadow dom for the popup. I use Shadow DOM due to level of encapsulation it provides.
You can read more about this here. Shadow DOM is recently been made available in browser that is why older version of browsers does not have it and some have it behind a flag. Firefox v63.0+ have this automatically available and there is no need for any config change, not sure why Waterfox does not have it enabled by default even in its latest version.
from dictionary-anywhere.
Thanks. A few follow-up questions:
- What do you mean by encapsulation?
- Why do you use it when other add-ons achieve pop-ups without it?
- Was there supposed to be a link in your reply? ("You can read more about this here.")
- What about dom.getRootNode.enabled?
from dictionary-anywhere.
Yeah missed the link: https://glazkov.com/2011/01/14/what-the-heck-is-shadow-dom/
By encapsulation I mean by popup is separated from other things in page and their CSS does not affect my popup.
I use function getRootNode, you can read about Shadow DOM, this is regarding that only, I downloaded WaterFox and tried the addon, and error was coming getRootNode is not a function then I saw we have to enable this config option.
Other addon if they do achieve they are simply not using shadow dom and it may cause style from outside bleed into their popup.
from dictionary-anywhere.
Thanks again. Looks pretty neat. Didn't understand it all, but the gist seems to be that essentially it's like an island for code in the page, like an iframe for a single object.
So getRootNode must also be enabled by default in newer/other browsers, and just disabled by default in Waterfox for some reason, so calling the function failed. Interesting. Anyways, it's good to know more about these entries. Thanks for all the info. :)
Feel free to close the issue when you want. I'd do it but not sure if you want to keep it open until you make changes to the instructions.
from dictionary-anywhere.
Related Issues (20)
- Always return "No definition found" HOT 9
- Not working while using "Reader View" HOT 3
- ER: Please add eugenics to dictionary & allow Dictionary Anywhere to work in the editable comments field of many websites HOT 1
- Feature request: allow multiple language selection HOT 1
- Feature Request: Google Translate HOT 1
- Feature Request: Please show gender of words in French! HOT 1
- Option to change default search engine when more is pressed HOT 2
- Website blocklist HOT 1
- [Feature Request] Add Czech support
- [Out of context request] Please hear me out - Would it be possible for an offline "Potplayer" version of this helpful tool?
- Pronunciation stopped working HOT 3
- [Feature Request] Adding keyboard shortcuts on Firefox
- No definition found HOT 1
- It Should Work On .PDF Files HOT 1
- Hey guys, I add the feature which is interact with slack
- dictionary not working HOT 4
- Feature request: Toggle to dd as a right click option rather than a double-click.
- Something else eating the double clicks?
- text bubble gets cut by browser window
- Popups stick on screen when drafting post in Tumblr
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dictionary-anywhere.