Giter Club home page Giter Club logo

Comments (6)

meeb avatar meeb commented on September 21, 2024 1

The above commit should filter emojis from the NFO title, source (used as show title), uploader (used as the studio) and description (used as the plot). It'll be bundled into the next release.

from tubesync.

meeb avatar meeb commented on September 21, 2024

You can trivially force the titles to be ASCII only, however this would break anything that requires unicode characters such as non-Latin alphabets. I don't use Kodi so can't really test this. Would stripping some UTF-8 chars such as just emojis but not other chars fix this?

from tubesync.

AshleyAshes avatar AshleyAshes commented on September 21, 2024

Well, I'm not entirely sure what to suggest, but there is def an issue with Kodi not accepting the characters. I've never run into this issue before, but when all previous scraping was using theTVDB, a source doesn't allow Emoji in names, or my own handwritten NFOs, it's just never been encountered before.

With Phil's Computer Lab however, some 795 videos, and a shocking amount containing Emoji, one even having Emoji in a filename, it caused a hell of a lot of problems. My solution was to batch convert the NFO files to ASCII. Manually editing the NFO files to remove those characters also worked but that was also rather slow.

Sorry to be hitting you with multiple issues, this is actually a super neat tool, I'm just running into issues here as I test it out.

Personally, I'd be fine with a 'Convert all characters to ASCII' with some friendly question marks or spaces where non-ASCII characters once were. If you wanted to filter specific characters, well you're the dev, but I'm not exactly sure which characters in UTF8 Kodi doesn't support.

from tubesync.

meeb avatar meeb commented on September 21, 2024

Seems related:

kodi-pvr/pvr.iptvsimple#163

As the NFO writing feature is pretty much just for Kodi and derivatives I don't mind patching this. I can strip just emojis and flags, it's pretty hacky (blanket stripping unicode sequences between large ranges) but possible. This appears to be a Kodi bug in general, but given it seems generally trivial to work around I'll pop it in the next release.

I won't add a force-everything-to-ASCII filter, otherwise if anyone (for example) downloads a video with a title in Japanese their title string in the NFO would be an empty string.

from tubesync.

AshleyAshes avatar AshleyAshes commented on September 21, 2024

That's great, thanks. Sorry for all these issues, I just was testing out TubeSync last night, I think it's great, but I'm running into cases where it breaks with Kodi, so sorry as I post these.

from tubesync.

meeb avatar meeb commented on September 21, 2024

All good, I don't think many people have deployed tubesync with Kodi so it's not unexpected you would find issues. This is the correct place to report issues!

from tubesync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.