Giter Club home page Giter Club logo

Comments (10)

medikoo avatar medikoo commented on June 2, 2024 1

Thanks @StoneCypher for reporting. Looking into that

from cli-color.

medikoo avatar medikoo commented on June 2, 2024 1

@StoneCypher great thanks for explaining in detail.

Indeed it doesn't look good in narrow window

As I check, I would either need to restructure the table so it has fewer items in a row (max 5 I assume) or insert an image instead.

I'll leave it open for now

from cli-color.

medikoo avatar medikoo commented on June 2, 2024 1

Thanks for ping. It was just published (CI is already configured, I just needed to bump version in package.json).

from cli-color.

medikoo avatar medikoo commented on June 2, 2024

Fixed now. Great thanks for reporting

from cli-color.

StoneCypher avatar StoneCypher commented on June 2, 2024

Semi-confirmed.

Don't know if you care, but the second table of colors shows as narrow strips rather than squares.

image

from cli-color.

medikoo avatar medikoo commented on June 2, 2024

Thanks, I see it as:

Screenshot 2022-06-05 at 11 51 29

What browser are you using?

from cli-color.

StoneCypher avatar StoneCypher commented on June 2, 2024

Ah. It's about width.

I discovered it because at my initial zoom, they were "normal" looking in Firefox, but zero-width and therefore invisible in Edge. Then I decided to take screenshots. After the firefox screenshot, and I went back to Edge, I decided to take them with the inspector out, so that you could see metrics. Then I had to go back to Firefox, and on opening the inspector, I saw it go from looks fine to what the hell

You can see it happen here

To stop this, observe that GitHub has a minimum width, and remove probably two columns, so that the color chips will still be at full width once the column is at minimum width.

The effect in the video has been successfully replicated on evergreen-current Chrome, Edge, and Firefox, all on Win10 pro x64

from cli-color.

StoneCypher avatar StoneCypher commented on June 2, 2024

yeah i think 5 is prolly max

note: what the hell is actually a technical term

from cli-color.

medikoo avatar medikoo commented on June 2, 2024

I've actually updated it, so it's presented via image.

If you have a better idea let me know, but I consider it as addressed at this point.

Great thanks for reporting it!

from cli-color.

StoneCypher avatar StoneCypher commented on June 2, 2024

Github fix confirmed.

NPM wasn't published. Would you like me to give you a gha auto-publisher script?

from cli-color.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.