Giter Club home page Giter Club logo

Comments (8)

CescaGarrett avatar CescaGarrett commented on August 26, 2024 1

CHT icon sq (1)

as requested, @abbyad

from cht-docs.

MaxDiz avatar MaxDiz commented on August 26, 2024

This is now fixed on the latest versions of firefox, chrome, and brave. Please reopen if experience same problem on earlier versions or other browsers

from cht-docs.

garethbowen avatar garethbowen commented on August 26, 2024

@MaxDiz The wrong icons still exist, eg: https://docs.communityhealthtoolkit.org/favicons/android-96x96.png

Also the wrong icon is still showing in my Firefox but this may be a caching issue.

The fix is to replace all the icons I listed above with the CHT icon. Alternatively you could remove the icon definitions in the header but I don't know how Hugo generates those.

from cht-docs.

SCdF avatar SCdF commented on August 26, 2024

On my desktop I get this:
image
Which means we aren't doing transparency correctly.

I also get the icon linked above by Gareth in Firefox Mobile, probably because that is pulling a different resolution.

from cht-docs.

abbyad avatar abbyad commented on August 26, 2024

Thanks for debugging. I'll regenerate all the icons and republish.

from cht-docs.

garethbowen avatar garethbowen commented on August 26, 2024

Bikeshed: Transparency in favicons is dangerous because you don't know what the colour of the tab will be. For example, with Stefan's colour it there is low contrast between the icon and the background so it risks getting lost. We were planning to replace the logo/favicon one day anyway so not a big deal I guess.

from cht-docs.

SCdF avatar SCdF commented on August 26, 2024

Bikeshed: Transparency in favicons is dangerous because you don't know what the colour of the tab will be. For example, with Stefan's colour it there is low contrast between the icon and the background so it risks getting lost. We were planning to replace the logo/favicon one day anyway so not a big deal I guess.

I'm talking about the transparency outside the teal border, not having the text transparent, I agree that would be bad. Looking at the browser tabs I have open right now, every single one either has a full square favicon with no space around it (eg hn) or it fills in the rest of the space with transparency (github, ddg, youtube).

from cht-docs.

abbyad avatar abbyad commented on August 26, 2024

Right, I put in transparency outside the teal border, not inside, so should display already in a variety of environments.

from cht-docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.