Add `"collect": "true"` to the properties files for all collect forms about cht-conf HOT 9 CLOSED

I think this is already done here: https://github.com/medic/medic-configurer/blob/c4ef0febd85c553b5e9f7f4526f8c0df9022a58e/src/fn/upload-collect-forms.js#L5

Is it not working anymore?

from cht-conf.

I just tested on beta-1.5.11 and it works, but only if you don't have a json properties file for that form with a context field.

from cht-conf.

Right, so I think we need to have it working for forms that already have json properties files, which will apply to many of our projects that are upgrading to 2.13.

from cht-conf.

I think the current behaviour is correct.

I just tested on beta-1.5.11 and it works, but only if you don't have a json properties file for that form with a context field.

What are you setting in the context field, if you aren't setting collect: true? Are there other options which might be relevant for a Collect form?

from cht-conf.

It looks to me like all the standard forms have unnecessary context fields set in their properties files. PR to remove these at https://github.com/medic/medic-projects/pull/2805.

from cht-conf.

I've already removed those in the 2.13 branch that I've been working on this week as part of the Standard push.

from cht-conf.

Previously we had:

{
	"context": {
		"person": false,
		"place": false,
		"expression": "false"
	}
}

and collect:true covers all of that

from cht-conf.

Great 👍

from cht-conf.

Thanks guys!

from cht-conf.