Comments (20)
🎉 This issue has been resolved in version 1.6.9 🎉
The release is available on:
Your semantic-release bot 📦🚀
from gatsby-plugin-robots-txt.
I am seeing the same issue after the update. The plugin documentation explicitly recommends setting sitemap
to null for dev/test.
from gatsby-plugin-robots-txt.
Seems to have come from the changes in #441
from gatsby-plugin-robots-txt.
@mdreizin Please re-open the issue. The fix wasn't merged in 1.6.8
CI output
semantic-release
didn't generate a new version. I think it happened because PR didn't include a commit message with the word fix
.
from gatsby-plugin-robots-txt.
yes, #441 breaks the possibility to have sitemap: null
as stated in the documentation
from gatsby-plugin-robots-txt.
cc @moonmeister
from gatsby-plugin-robots-txt.
Yup, we just need a null check and some tests probably. I'll do it if I find time.
from gatsby-plugin-robots-txt.
@moonmeister @laurenskling @eDubrovsky I am really sorry, but I don't have a free time to fix that issue. I would appreciate if someone could look at it and fix.
from gatsby-plugin-robots-txt.
@mdreizin or whomever...I'm trying to understand how you're getting an error thrown here. the lines 59-69 of this code should check for this null value and properly fill in the site url from the siteUrl
metadata. So if this value is truly null
then you must not be setting siteUrl
. The whole point of setting the plugin config sitemap
value to null
is to fallback to that other value...if both are null we can provide a cleaner error but there's nothing we can do. Can you better explain what's happening or what you expect to happen? Links to your gatsby-config.js
files could be helpful in fixing this bug. Thanks
from gatsby-plugin-robots-txt.
Just realized those existing if statements aren't null checks, they're checking for existing properties, null or not. I'll look at this again and see what what I can figure out.
from gatsby-plugin-robots-txt.
Has this issue been resolved?
I seem to get the same issue.
from gatsby-plugin-robots-txt.
I don't believe so.
from gatsby-plugin-robots-txt.
@moonmeister could I just reroll to an older version of the plugin and then this issue wouldn't exist?
or should i change sitemap: null to something else?
from gatsby-plugin-robots-txt.
Sure but you'll have other issues that this update solved. I may have time to check this out soon. Feel free to contribute a fix too.
from gatsby-plugin-robots-txt.
Can we please have a release of the fix? 😅
from gatsby-plugin-robots-txt.
Please check the latest version.
from gatsby-plugin-robots-txt.
Please check the latest version.
@mdreizin I don't think that the npm version is synced with the current repo version.
from gatsby-plugin-robots-txt.
The merge isn't released into a release, would that be possible @mdreizin ?
from gatsby-plugin-robots-txt.
@mdreizin this fix not merged into the 1.6.8 version. 😿
from gatsby-plugin-robots-txt.
Updated to most recent version of gatsby-plugin-robots-txt and our builds aren't running bc of the above. Any updates on when this will be fixed?
from gatsby-plugin-robots-txt.
Related Issues (20)
- Trying to use multiple sitemaps HOT 1
- Vulnerability [ Prototype Pollution] HOT 4
- Gatsby try to load gatsby-node.js source in a non-existent path HOT 4
- Add the option to disable the host directive to the README HOT 1
- [question] how to use with firebase HOT 1
- How to disallow custom pages based on enviromental variables. HOT 1
- Support for v4 of gatsby-plugin-sitemap HOT 1
- Netlify build errors HOT 9
- how to add additional info like # Algolia-Crawler-Verif in robots.txt file HOT 2
- Gatsby4 support HOT 5
- Cannot fine modules fs/promises
- Cannot find module fs/promises HOT 1
- Error in "/var/www/html/node_modules/gatsby-plugin-robots-txt/gatsby-node.js": Cannot find module 'fs/promises'
- "Host:" may be invalid HOT 2
- Setting policies array dynamically using Strapi Page List
- Update sitemap default to match Gatsby v5 HOT 1
- Updating to 1.8.0 breaks gatsby 2.x compatibility HOT 7
- Can't add sitemap under userAgent: '*' HOT 2
- Incompatible with Gatsby v4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gatsby-plugin-robots-txt.