Comments (16)
Thank you for your contribution!
from survol.
This is gonna be my first issue. Mind if I give it a shot ?
from survol.
yes go on good luck, I'll assign this one to you then
from survol.
Okay so how exactly does the extension work ? As in when does it show me the preview. Do I need to hover over the link or ? I have cloned the repo and added the extension
from survol.
Yes you have to hover the link, you should find a test page at html/test.html
with every working platform / type of link
from survol.
Have you considered having seperate blocks for comments and posts ?
from survol.
what do you mean ?
from survol.
Nothing nothing. stupid question. forget it. sorry
from survol.
Hey do you want it to look like what you have done for the reddit comment ?
from survol.
Yes that's the idea I guess ? If you've something better go for it
from survol.
Is it okay if I use a black icon instead of the orange one ? I think there are IPR issues with the orange since this isn't official reddit stuff
from survol.
We're embedding reddit content I believe there should be no problem using the reddit icon as its their content? If their normal card were working we would be using those, and those cards would have official reddit branding
from survol.
I am almost done. Should be raising a PR in a few hours.
from survol.
Are you happy with it or you want some changes ?
from survol.
The issue is closed and I merged your PR, I still did some minor changes but it was good overall.
from survol.
I know. I saw that you made a few changes and closed it. Just wanted to check if you needed anything else. It was really nice working on your repo. Thanks for the opportunity 😁
from survol.
Related Issues (20)
- Implement direct link to images HOT 2
- Add other websites from the StackExchange network to the StackExchange implementation HOT 5
- Make the survol preview interactive HOT 2
- The survol container should display a placeholder / loading icon HOT 6
- Implement soundcloud profile pages HOT 1
- Onboarding page HOT 2
- List of missing translations : HOT 8
- Rework the landing page HOT 9
- Add a blacklist to deal with website that already have a preview for inner links HOT 18
- The survol container is removed from the DOM in SPA
- Add a badge on the extension icon HOT 1
- Add custom templates for websites supporting oEmbed
- Cache the changelog on onboarding page HOT 2
- Feature request: thumbshots/previews of all websites HOT 3
- Feature request: Inject in existing web pages HOT 1
- Add some indicator while fetching the preview HOT 1
- Make a version for Microsoft Edge HOT 2
- Customizable Wait-Time HOT 1
- SPF +all mechanism should not be used at survol.me
- [Bug] - Make Inoreader hard to load
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from survol.