Giter Club home page Giter Club logo

Comments (16)

mdolr avatar mdolr commented on May 23, 2024 1

Thank you for your contribution!

from survol.

rohithjayaraman avatar rohithjayaraman commented on May 23, 2024

This is gonna be my first issue. Mind if I give it a shot ?

from survol.

mdolr avatar mdolr commented on May 23, 2024

yes go on good luck, I'll assign this one to you then

from survol.

rohith-jayaraman avatar rohith-jayaraman commented on May 23, 2024

Okay so how exactly does the extension work ? As in when does it show me the preview. Do I need to hover over the link or ? I have cloned the repo and added the extension

from survol.

mdolr avatar mdolr commented on May 23, 2024

Yes you have to hover the link, you should find a test page at html/test.html with every working platform / type of link

from survol.

rohith-jayaraman avatar rohith-jayaraman commented on May 23, 2024

Have you considered having seperate blocks for comments and posts ?

from survol.

mdolr avatar mdolr commented on May 23, 2024

what do you mean ?

from survol.

rohith-jayaraman avatar rohith-jayaraman commented on May 23, 2024

Nothing nothing. stupid question. forget it. sorry

from survol.

rohith-jayaraman avatar rohith-jayaraman commented on May 23, 2024

Hey do you want it to look like what you have done for the reddit comment ?

from survol.

mdolr avatar mdolr commented on May 23, 2024

Yes that's the idea I guess ? If you've something better go for it

from survol.

rohith-jayaraman avatar rohith-jayaraman commented on May 23, 2024

Is it okay if I use a black icon instead of the orange one ? I think there are IPR issues with the orange since this isn't official reddit stuff

from survol.

mdolr avatar mdolr commented on May 23, 2024

We're embedding reddit content I believe there should be no problem using the reddit icon as its their content? If their normal card were working we would be using those, and those cards would have official reddit branding

from survol.

rohith-jayaraman avatar rohith-jayaraman commented on May 23, 2024

I am almost done. Should be raising a PR in a few hours.

from survol.

rohithjayaraman avatar rohithjayaraman commented on May 23, 2024

Are you happy with it or you want some changes ?

from survol.

mdolr avatar mdolr commented on May 23, 2024

The issue is closed and I merged your PR, I still did some minor changes but it was good overall.

from survol.

rohithjayaraman avatar rohithjayaraman commented on May 23, 2024

I know. I saw that you made a few changes and closed it. Just wanted to check if you needed anything else. It was really nice working on your repo. Thanks for the opportunity 😁

from survol.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.