Giter Club home page Giter Club logo

Comments (1)

queengooborg avatar queengooborg commented on July 18, 2024

It appears that this is caused by the check to see if an object has a __compat property inside of it. This check ensured that we weren't attempting to order the members of compatibility statements, since their ordering was handled separately in the other files. Unfortunately, this check also assumed that the top level of a file had a __compat statement -- in other words, it expected global_attributes to have a __compat statement. This means it's also affecting various files within the JavaScript category, such as grammar and statements.

Ultimately, I think that this is a fatal flaw in the way that the ordering script is programmed. Since we're using the replacer parameter of JSON.stringify, we have no context of what level or path we're at in the JSON; we only know the key and value we're looking at.

To solve this, I believe that a rewrite of the ordering script(s) would be needed. The ordering script would need to be written in a way where we can track the current path and depth, track what kind of object (relative to the schema) we're modifying, and ultimately, ensure we're sorting everything we can. This would also be a good opportunity to merge the ordering scripts into one script.

from browser-compat-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.