Comments (4)
Thank you for your quick response.
I would like to apologize you for the inconvenience. Now I can see that our projects have a lot of common (more than I was thinking). I couldn’t tell it directly because parts of the code that you mentioned weren’t written by me. These parts of the code were added to our project by our former developer and I don’t know that other part of code well yet. Our project is also MIT-licensed and we respect licenses of other projects so of course, we’ll add information about Reactstrap to our project.
Again please accept our sincerely apologizes
from mdb-react-ui-kit.
Another thing you can do, which is probably better, is to just include reactstrap (via npm) and extend the components reactstrap provides. Most of the components would just be exposed as is, some of the components (like Narbar) you can easily extend without needing to copy any of reactstrap's code (Just add only your extra classes to reactstrap's Navbar and you will get the same result). Then you would not need to include the license as reactstrap's code is not in your project. The license will be included when user perform an npm install and actually retrieve reactstrap (as it is with pretty much every package on npm).
We were considering using MDB-react as part of our stack and we are currently reconsidering unless the above approach is taken, the reasoning is 1) To improve visibility to the original authors 2) To get updates from the original project, which is obviously best suited to handle this piece of code 3) To make it apparent what are the additions from the MDB-react project and and allow for better extensibility from the endusers
from mdb-react-ui-kit.
Our project is similar to yours, but we didn't use your code. Could you please point me where do we use your code?
from mdb-react-ui-kit.
The components which have substance are the obvious offenders:
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/Collapse.js
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/Dropdown.js
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/DropdownItem.js
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/DropdownMenu.js
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/DropdownToggle.js
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/Fade.js
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/Media.js
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/Modal.js
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/utils.js
Some components have been expanded to add specific features for this project, but they are obviously a derivative of the original work from reactstrap as well
https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/Navbar.js
But even then simple components clearly have been copied. Even thought they are simple enough to understand how two projects came up with the same output, it is clear that they were just copied. The variable names, declaration order and usage (including prop order), as well as comments in the code are is the same. It's very obvious that this project just moved the propType
and defaultProp
declarations to be inline. On a few components some props were removed (such as tag
and cssModule
) but other components did keep those.
(A list of ~80% of the remaining components goes here (A shorter list would be things not copied). If you need me to actually list them and point out how they are copies or derivatives of reactstrap I can in the DMCA Takedown Notice I will submit.)
Also, some of the components have the same typos and incorrect default values (which have been addressed in reactstrap, but apparently after they were copied here)
Tether values, which reactstrap used to use and this project didn't: https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/blob/master/src/components/utils.js#L1-L107
reactstrap switched to react-popper, just only after the utils.js was copied by this project.
Badge has an invalid default color of "default" which bootstrap doesn't have, it's actually "secondary". reactstrap has "default" but has since changed to "secondary" apparently after they were copied here.
If you understand this project copies and uses [a lot of] material from reactstrap, either directly or indirectly as derivative work, all you have to do is include the LICENSE (here and in distributed files such as direct downloads from your website) and everything is good.
Another thing you can do, which is probably better, is to just include reactstrap (via npm) and extend the components reactstrap provides. Most of the components would just be exposed as is, some of the components (like Narbar) you can easily extend without needing to copy any of reactstrap's code (Just add only your extra classes to reactstrap's Navbar and you will get the same result). Then you would not need to include the license as reactstrap's code is not in your project. The license will be included when user perform an npm install
and actually retrieve reactstrap (as it is with pretty much every package on npm).
If you still do not believe this project blatantly includes reactstrap copyright without the license to do so, I will submit a DMCA Takedown Notice and let the legal powers that be determine that.
from mdb-react-ui-kit.
Related Issues (20)
- Broken MDBCollapse component in version 2.1.0 HOT 1
- Dropdown menu position issue HOT 1
- TimePicker can not get the value I set HOT 1
- ReferenceError: document is not defined HOT 1
- Replace 'transition-property' with 'transition' HOT 2
- MDBDropdown has issue when using in react-styleguidist HOT 6
- Question: mdbreact vs mdb-react-ui-kit - which package is better? HOT 4
- cli is looking for react v17 HOT 1
- Runtime error HOT 1
- MDBModal keeps display:block after 2nd time closed HOT 7
- Module parse failed error HOT 2
- MDBCollapse keep height after animation ends HOT 2
- MDBCollapse does not have onHide and onShow events HOT 3
- uncaught TypeError: Failed to execute 'getComputedStyle' occurs and keeps racking up but doesnt crash anything HOT 7
- Failed to execute 'getComputedStyle' on 'Window' HOT 1
- Using MDBootstrap with next.js App Router HOT 1
- Error when installed version of chart.js is > 4.3.3
- Uncaught TypeError when setting leaveHiddenModal to false on MDBModal HOT 1
- Community & Migration HOT 1
- Warning in the console for MDBDataTable from mdbreact
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdb-react-ui-kit.