Giter Club home page Giter Club logo

Comments (3)

carolynvs avatar carolynvs commented on June 15, 2024
install:
- helm3:
     chart: ...
     namespace: myns
     create-namespace: false # default to true, preserves existing behavior

I am not a fan of making boolean config values that default to true, but it lines up well with the name of the flag, and we are already doing it for the atomic flag too so I feel like that would be most consistent.

What do you think?

from porter-helm3.

lucasmaheo avatar lucasmaheo commented on June 15, 2024

I agree that it is slightly confusing that users would have to specify create-namespace: false to disable. It is consistent with itself, just not with helm.

I think that's a good workaround for now to ensure compatibility with most and keeping current behaviour. In a future release I would still recommend to match as closely as possible helm behaviour: same defaults, same flags. Boolean flags are really easy to implement, it's a shame not to expose them.

from porter-helm3.

thomasthep avatar thomasthep commented on June 15, 2024

I just went ahead and implemented this as it's currently blocking our ability to deliver the bundle to customers.
Feel free to merge or request changes.

from porter-helm3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.