Giter Club home page Giter Club logo

Comments (11)

mcchrish avatar mcchrish commented on May 31, 2024 1

@ldelossa welcome! and thanks for the detailed bug report.

from nnn.vim.

mcchrish avatar mcchrish commented on May 31, 2024

So you mean the other buffer windows are being closed when opening a file via nnn using the custom action key-bindings? What's your vim/neovim version?

from nnn.vim.

ldelossa avatar ldelossa commented on May 31, 2024

@mcchrish

I went to retry this, but now I cannot get ctrl-x and crtl-v to open in a split. Is there a known issue? Here is my vimrc - https://github.com/ldelossa/dotfiles/blob/master/vimrc

When I attempt a ctrl-x in the nnn window, it simply opens the file in the current buffer, no split is used.

from nnn.vim.

mcchrish avatar mcchrish commented on May 31, 2024

Hi @ldelossa thanks for getting back on the issue. I'm able to replicate the bug.
I made a branch that contains a fix to be tested. You can test it using Plug 'mcchrish/nnn.vim', { 'branch': 'fix-issue-27' }.

from nnn.vim.

ldelossa avatar ldelossa commented on May 31, 2024

@mcchrish that did fix the issue. And now I can give a better example of the issue I face.

Open one buffer, and have nnn open a horizontal split:
image

Now I put focus on the buffer below, and I open nnn, and I want to make a vertical split. My assumption is that the bottom buffer gets split into two. But instead a vertical split takes over both buffers:

image

There is also a quick error message that pops up when attempting to do that which I didn't catch.

My desired result using netrw is as follows:

image

Contents of the buffers are arbitrary, just the layout is what I'm expressing.

from nnn.vim.

mcchrish avatar mcchrish commented on May 31, 2024

You can check the error my running :messages.

I think I got it fixed. It might be due to the split explorer feature I've added, and the internal logic of switching back previous buffer from the nnn buffer after opening a file. Do you mind testing again?

from nnn.vim.

ldelossa avatar ldelossa commented on May 31, 2024

@mcchrish looks like the issue is still there. It seems like any buffer manipulation I try that involves more then two spits (whether horizontal or vertical) results in only two buffers (the newly created split is just placed as a full length vertical or horizontal buffer with the other one currently in focus)

from nnn.vim.

mcchrish avatar mcchrish commented on May 31, 2024

I somehow able to replicate the issue, but fixed in the latest commit.

What's the output of :messages after seeing the issue? Can you reproduce it with a minimal vimrc? e.g.

" minimalvimrc file
set nocompatible
set noswapfile

call plug#begin('~/.local/share/nvim/plugged')
Plug 'mcchrish/nnn.vim', { 'branch': 'fix-issue-27' }
call plug#end()

let g:nnn#action = {
      \ '<c-x>': 'split',
      \ '<c-v>': 'vsplit' }

Then nvim -u minimalvimrc

from nnn.vim.

mcchrish avatar mcchrish commented on May 31, 2024

screen shot 2019-01-22 at 8 54 59 am

I get this result afterwards. Steps:
  1. open nvim
  2. run :NnnPicker
  3. open a file pressing enter
  4. run :NnnPicker
  5. open a file pressing <c-x> to open it in a split
  6. focus on the split below
  7. run :NnnPicker
  8. open a file pressing <c-v> to open it in a vertical split

from nnn.vim.

ldelossa avatar ldelossa commented on May 31, 2024

@mcchrish my fault, plug didn't update to the latest commit. This in fact working now!

Thanks this is a much better workflow now.

from nnn.vim.

ldelossa avatar ldelossa commented on May 31, 2024

Anytime.

from nnn.vim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.