Use Statefulset for pods when using persistent storage about amq-broker-helm HOT 5 CLOSED

What is the use case here? This chart is really meant for a single-pod deployment for now, there is no storage re-allocation (and the persistent volume is declared as Read-Write-Once).
I see no real benefit in switching to StatefulSets unless you want to use this chart to deploy an highly available AMQ service, which for this particular chart is out of scope.
I am working on that in the clustered-persistence chart which has still many issues (namely routes and nodeports)

EDIT: anyways, I made the required changes in another branch (have a look here). It's rough on the edges but it's a start :)

from amq-broker-helm.

I suggest that we have a field for choosing Deployment vs StatefulSet.
I have created a pull-request towards "mcaimi:persistence-statefulset":

#14

from amq-broker-helm.

Saw it, I like the approach. I merged the pull-request.
I'll maybe pull it back to the master branch since now it basically support both kinds of deployments

from amq-broker-helm.

The service should probably only be headless when StatefulSet is used:

spec:
  {{- if eq .Values.kind "StatefulSet" }}
  clusterIP: None
  {{- end }}
  type: ClusterIP

from amq-broker-helm.

Yes that's right, I've updated the service template and have pulled back all commits into the master branch.

from amq-broker-helm.