Giter Club home page Giter Club logo

Comments (2)

mcabbott avatar mcabbott commented on June 5, 2024

Thanks, that's a bug. I think this isolates it to mcabbott/LazyStack.jl#15

julia> euclideanize(P[:,4,:])
2×100 Matrix{Float64}:
 1.93102   1.61322  0.727326  0.626134  1.35614     1.27111   0.463712  2.29733  2.68379
 0.113882  1.52248  1.03129   0.626155  0.292362     0.839144  0.118597  1.97182  6.95894

julia> @cast u[i,k] := euclideanize(P[:,4,:])[i,k]; summary(u)
"2×100×1 lazystack(::Tuple{Matrix{Float64}}) with eltype Float64"

julia> @pretty @cast u[i,k] := euclideanize(P[:,4,:])[i,k]
begin
    @boundscheck ndims(P) == 3 || throw(ArgumentError("expected a 3-tensor P[:, 4, :]"))
    local dolphin = sliceview(view(P, :, 4, :), (:, :))
    local pig = @__dot__(euclideanize(dolphin))
    local armadillo = lazystack(pig)
    u = armadillo
end

julia> TensorCast.sliceview(view(P, :, 4, :), (:, :)) |> summary
"0-dimensional Array{SubArray{Float64, 2, Array{Float64, 3}, Tuple{Base.Slice{Base.OneTo{Int64}}, Int64, Base.Slice{Base.OneTo{Int64}}}, false}, 0}"

julia> TensorCast.sliceview(view(P, :, 4, :), (:, :)) .|> euclideanize |> summary
"2×100 Matrix{Float64}"

julia> TensorCast.sliceview(view(P, :, 4, :), (:, :)) .|> euclideanize |> TensorCast.lazystack |> summary
"2×100×1 lazystack(::Tuple{Matrix{Float64}}) with eltype Float64"

Ideally perhaps @cast would recognise that euclideanize(P[:,4,:]) is a function like rand(2,100) which it should pull out, as it contains no indexing that the macro ought to do anything about. But it does not see this.

from tensorcast.jl.

mcabbott avatar mcabbott commented on June 5, 2024

This is fixed in LazyStack v0.1.1, btw. I leave the issue open as a reminder to add a test here too.

from tensorcast.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.