Giter Club home page Giter Club logo

Comments (2)

buddhike avatar buddhike commented on August 29, 2024

@sergey-ostapenko Thanks for the continued support with great suggestions. Is this working as expected?

from mbt.

sergey-ostapenko avatar sergey-ostapenko commented on August 29, 2024

@BuddySpike I just found some counter arguments against the idea to be taken into account.

From the scripting perspective in CI \ CD process it could be more convenient to leave the functionality as is. Just because we almost always operating with merge base commit, or previously build commit. Both of them are telling us about build start point, but should not be included into the build.
Taking it into account, maybe we should change original proposal to be:

Allow two different options to setup start point of the build:

  1. --base for automation scenarios
  2. --from for human interaction, where from is inclusive. Because it is not convenient to do extra work to work with just one commit for which you already have sha1.

So if you think it is reasonable, we can re-open the issue, or alternatively we can just create new one that will better capture suggestion details.

from mbt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.