Giter Club home page Giter Club logo

Comments (2)

buddhike avatar buddhike commented on August 29, 2024

This is largely due to blind workspace traversal we do to detect modules in locally. It traverses the entire directory tree without respecting .gitignore. As a result, if you run local commands on repository with say... node_modules, it might take up a few seconds.

Having said that, we revised this implementation recently to address a different issue and in the process I realised that we should be able to discover modules without traversing the file system quite efficiently. It requires changing the below routine to perform two tasks:

  • Discover modules in head
  • Discover modules in workspace (same as what you get when you run mbt describe local
    And union the two sets.
  • Finally get rid of ModulesInWorkspace function in discover.go

https://github.com/mbtproject/mbt/blob/master/lib/manifest_builder.go#L134

It will be much faster.

from mbt.

sergey-ostapenko avatar sergey-ostapenko commented on August 29, 2024

As a result, if you run local commands on repository with say... node_modules, it might take up a few seconds

Exactly our situation, but we have a lot of node_modules folders. So it would be great to have these improvements to allow use this tool more efficiently.

Btw, just noticed that:
mbt describe head
is working many times faster than
mbt describe local --all
Have it been optimized already?
Really looking forward to this optimization 👍

from mbt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.