Goroutine leaking about grpc-consul-resolver HOT 2 CLOSED

Closing res can lead to a panic in the goroutine.

From the tour page you linked to:

A select blocks until one of its cases can run, then it executes that case. It chooses one at random if multiple are ready.

So if there's an ee result and quit is closed, it chooses randomly, and if it selects the <- ee one, but res is also closed, it will panic.

You can take the code from the tour page you linked to and adapt it a bit and when running it multiple times, it will lead to a panic sometimes (only sometimes because of the random selection): https://play.golang.org/p/isJ_jcKPYwg

I think it's safer to only close quit. res should then be garbage collected at some point.

from grpc-consul-resolver.

@tie Good catch. Thanks. I'll check and fix.

from grpc-consul-resolver.