Very slow for first generation about mbknor-jackson-jsonschema HOT 8 CLOSED

not the OP, but

In which cases the entire classpath should be scanned ?

none, not ever, bad idea, ask the developer to provide a package name from which to start scanning so you don't end up scanning every library ever, Possibly have an annotation (like spring boot does) to say where classpath scanning should start. Also possibly make it possible not to scan, instead simply provide a list of classes.

from mbknor-jackson-jsonschema.

Any feedback on #75 would be apreciated

from mbknor-jackson-jsonschema.

Hi,

This problem is caused by this line:

https://github.com/mbknor/mbknor-jackson-jsonSchema/blob/master/src/main/scala/com/kjetland/jackson/jsonSchema/JsonSchemaGenerator.scala#L22

It scans the entire classpath. An improvement would be to make this configruable.
A PR fixing this would be great 😀

from mbknor-jackson-jsonschema.

Thanks for your answer.

Could you please give some details about this making configurable.

In which cases the entire classpath should be scanned ?
Should i filter the scan root or disable scan according to config?
İf we disable this which features won't work?

from mbknor-jackson-jsonschema.

Yeah, this issue makes the library almost unusable for large projects, not only slowing things down to a crawl, but causing OOM failures.

from mbknor-jackson-jsonschema.

I'm Not currently using this library on a daily basis anymore, but i'll try to get time to fix this

from mbknor-jackson-jsonschema.

Fixed in 5391586

from mbknor-jackson-jsonschema.

Fixed in version to 1.0.30

from mbknor-jackson-jsonschema.