Crashes on long string length about mbbsemu HOT 5 CLOSED

@dlightman311 Do you know what is supposed to happen here on real MBBS? Does it truncate the userid to 30 characters? Reject with an error message? Something else?

from mbbsemu.

The length of USERID in the USERACCOUNT struct is char[30], so 29 character + null terminator

from mbbsemu.

The issue is when logging it, it builds the UserAccount struct, and assigns the entered username to the struct value UserAccount.username

https://github.com/enusbaum/MBBSEmu/blob/master/MBBSEmu/HostProcess/HostRoutines/MenuRoutines.cs#L194

We need to add additional validation to this routine so that it doesn't allow input of usernames longer than acceptable.

Probably to signup as well.

from mbbsemu.

At the login prompt real MBBS allows 128 chars to be entered and disconnects the telnet session at 129:

This could be MajorTCP disconnecting the telnet session rather than MBBS. At a local login session I can enter up to 127 chars and input stops displaying:

At the new user signup username question real MBBS presents a field of 30 chars, allows the user to enter in up to 29 and stops displaying input:

from mbbsemu.

Closed with PR #79

from mbbsemu.