Comments (5)
then im guessing this is also a fernflower issue. try decompiling with the default decompiler(simply replace --decompile fernflower
with --decompile
or -d
)
from minecraftdecompiler.
Thanks. This solved nested classes not getting decompiled but leads to other problems.
E.g. in com.mojang.math.OctahedralGroup
the renamed local variables (method parameters) are not decompiled correctly:
private OctahedralGroup(final String param3, final SymmetricGroup3 param4, final boolean param5, final boolean param6, final boolean param7) {
this.name = s;
this.invertX = flag;
this.invertY = flag1;
this.invertZ = flag2;
this.permutation = symmetricgroup3;
this.transformation = new Matrix3f().scaling(flag ? -1.0F : 1.0F, flag1 ? -1.0F : 1.0F, flag2 ? -1.0F : 1.0F);
this.transformation.mul(symmetricgroup3.transformation());
}
s
, flag
, and so on are unknown symbols, because function parameters are called param
X.
With using FernFlower as decompiler the rename option of MinecraftDecompiler is handled correctly:
private OctahedralGroup(final String s, final SymmetricGroup3 symmetricgroup3, final boolean flag, final boolean flag1, final boolean flag2) {
this.name = s;
this.invertX = flag;
this.invertY = flag1;
this.invertZ = flag2;
this.permutation = symmetricgroup3;
this.transformation = (new Matrix3f()).scaling(flag ? -1.0F : 1.0F, flag1 ? -1.0F : 1.0F, flag2 ? -1.0F : 1.0F);
this.transformation.mul(symmetricgroup3.transformation());
}
from minecraftdecompiler.
https://github.com/MaxPixelStudios/MinecraftDecompiler/actions/runs/9148385977
you can download and use the artifact in this run
this version uses an updated version of vineflower
from minecraftdecompiler.
an alternative is to use the user-defined decompiler:
put the config file at decompiler/decompiler.properties
follow the config file and put your decompiler jar at the right path
decompiler.txt
github doesn't allow uploading .properties files, you need to rename it yourself
if you did everything right, you will get something like this except that vineflower is version 1.10.1
then replace arg -d
with -d user-defined
and run mcd
from minecraftdecompiler.
Close as this is a decompiler error, which is not the problem on this project's end.
Integrated decompilers may be outdated, but you can use their latest version through the user-defined decompiler feature.
from minecraftdecompiler.
Related Issues (20)
- [BUG] Idk if im stupid but the jar isnt working HOT 3
- [BUG] [3.3-SNAPSHOT] `*` could expand to other things in a terminal HOT 17
- [Enhancement] Omit -t for namespaced mappings if there are only two namespaces
- [Enhancement] ParchmentMc Mappings
- [Enhancement] Support unpick
- [Enhancement] Support Quilt Mappings HOT 3
- [Enhancement] Mapping Provider API
- Cannot decompile latest snapshots HOT 3
- [Feature Request] Download CFR/FernFlower when use them to decompile
- [BUG] [2.2-3.0] Incorrectly remapping unmapped array type to mapped type
- [Feature Request] An intermediary API between PairedMapping and NamespacedMapping
- [Feature Request] Refactor `ILibRecommendedDecompiler`
- [BUG] [3.1] Cannot remap some descriptors
- [BUG] [3.1] Directory wrongly unzipped
- [Enhancement] `extraClasses` option
- [Enhancement] Mapping format inference
- [Enhancement] Support mixin classes
- [Enhancement] Interactive console
- [BUG] [3.2] Not working (idk english well, sorry) HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minecraftdecompiler.