[BUG] [3.3.2] Nested public classes are not decompiled. about minecraftdecompiler HOT 5 CLOSED

then im guessing this is also a fernflower issue. try decompiling with the default decompiler(simply replace --decompile fernflower with --decompile or -d)

from minecraftdecompiler.

Thanks. This solved nested classes not getting decompiled but leads to other problems.

E.g. in com.mojang.math.OctahedralGroup the renamed local variables (method parameters) are not decompiled correctly:

private OctahedralGroup(final String param3, final SymmetricGroup3 param4, final boolean param5, final boolean param6, final boolean param7) {
      this.name = s;
      this.invertX = flag;
      this.invertY = flag1;
      this.invertZ = flag2;
      this.permutation = symmetricgroup3;
      this.transformation = new Matrix3f().scaling(flag ? -1.0F : 1.0F, flag1 ? -1.0F : 1.0F, flag2 ? -1.0F : 1.0F);
      this.transformation.mul(symmetricgroup3.transformation());
   }

s, flag, and so on are unknown symbols, because function parameters are called paramX.

With using FernFlower as decompiler the rename option of MinecraftDecompiler is handled correctly:

private OctahedralGroup(final String s, final SymmetricGroup3 symmetricgroup3, final boolean flag, final boolean flag1, final boolean flag2) {
        this.name = s;
        this.invertX = flag;
        this.invertY = flag1;
        this.invertZ = flag2;
        this.permutation = symmetricgroup3;
        this.transformation = (new Matrix3f()).scaling(flag ? -1.0F : 1.0F, flag1 ? -1.0F : 1.0F, flag2 ? -1.0F : 1.0F);
        this.transformation.mul(symmetricgroup3.transformation());
    }

from minecraftdecompiler.

https://github.com/MaxPixelStudios/MinecraftDecompiler/actions/runs/9148385977
you can download and use the artifact in this run
this version uses an updated version of vineflower

from minecraftdecompiler.

an alternative is to use the user-defined decompiler:
put the config file at decompiler/decompiler.properties
follow the config file and put your decompiler jar at the right path

decompiler.txt
github doesn't allow uploading .properties files, you need to rename it yourself

if you did everything right, you will get something like this except that vineflower is version 1.10.1

then replace arg -d with -d user-defined and run mcd

from minecraftdecompiler.

Close as this is a decompiler error, which is not the problem on this project's end.

Integrated decompilers may be outdated, but you can use their latest version through the user-defined decompiler feature.

from minecraftdecompiler.