Comments (17)
The encode and decode functions are defined within webassembly. They are here: https://github.com/maxmcd/webtty/blob/master/web-client/src/main.go#L60-L63
(Webassembly can't mutate the global javascript state by itself but wasm_exec.js allows Go to call into the browser context)
If there was an error loading the webassembly those functions would not be available, but assuming success decode and encode should be available on the window
object.
Appreciate you looking into this, I still haven't been able to reproduce on my end, will look into it again.
from webtty.
Can you paste your offer message?
from webtty.
Actually, if you could email it to me. Email addr is on my github profile.
from webtty.
I will send you one, but really any offer triggers the same problem (it already breaks as soon as I start typing).
from webtty.
Ping
from webtty.
I'm having this issue. I have the same error in Firefox and in chrome the error I have is:
OperationError: Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': Failed to parse SessionDescription. Expect line: v= InvalidStateError: Failed to execute 'createAnswer' on 'RTCPeerConnection': PeerConnection cannot create an answer in a state other than have-remote-offer or have-local-pranswer.
This error occurs on key any press - I don't even think it recognizes the entire offer I paste in :/
from webtty.
UPDATE: I looked into the source the issue appears to be a missing decode function
in the startSession
function:
Furthemore, to get it connect to a session you need to put your offer in the url as a hash argument - e.g: http://localhost:8080/#connection_data
I'm not sure whether the on("data"
function parses the paste correctly since if refreshes the term
as soon as a key is pressed which may not be what we need.
from webtty.
The url hash was intended as a convenience, it shouldn't be required.
from webtty.
Thanks for the quick reply!
This is my system information, hopefully it helps:
Fedora 29, kernel 4.19.13-300
all up to date.
Docker version 18.09.1, build 4c52b90
docker-compose version 1.22.0, build f46880f
Running docker-compose up
builds everything successfully (Though it complains about the nodejs
version so I had to remove it manually to download the latest):
Successfully built 403eef497ede
Successfully tagged maxmcd/webtty-client:latest
Starting webtty_web-client_1 ... done
Recreating webtty_base_1 ... done
Attaching to webtty_web-client_1, webtty_base_1
webtty_base_1 exited with code 0
web-client_1 | 172.20.0.1 - - [18/Jan/2019:13:39:40 +0000] "GET / HTTP/1.1" 200 263 "-" "curl/7.61.1" "-"
Any clues would be much appreciated,
Thanks
from webtty.
Hmmmm... I also run fedora, one system was fc28 the other fc29. Will try to test again soon.
from webtty.
Hey @arjenpdevries,
Any updates? :)
from webtty.
This seems to imply to me that WebTTY is just unusable for some/all users? I can't get an example working and I don't know how to resolve it at all.
from webtty.
@rivertam maybe!
I can get it working, this issue seems to (weirdly) be limited to Fedora. What kind of issue are you experiencing? (Feel free to open another issue or email me 😃 )
from webtty.
I'm actually experiencing this on Ubuntu with the exact same issues as above. I didn't look into this properly when I commented -- I'll see if there are errors in the console tomorrow.
from webtty.
Given the report with Ubuntu above, it does not seem related to the linux distribution:
#5 (comment)
from webtty.
Hey guys, mind checking this out with the new release?
from webtty.
If I right-click and paste, instead of trying a ctrl-v in the window, the demo works. Suspect it's just the web client that's having this problem due to changes there.
edit: oops, just saw the fix above. my bad.
from webtty.
Related Issues (20)
- Issue with initial handshake HOT 2
- Chinese with your README.md , if you like
- SDP Use and Security Clarifications HOT 3
- Connection hangs HOT 4
- Quitting with an unexpected error: "failed to parse IP address" HOT 4
- error on web https://maxmcd.github.io/webtty/
- Upgrade to pion/webrtc@v3
- Upgrade WASM code to Go 1.12+
- Disable circle-ci testers HOT 1
- Setup golangci-lint
- Setup code coverage
- prebuilt binaries for arm (raspberry and company) HOT 1
- passing the key as an argument in URL HOT 1
- Support for macOS? HOT 7
- [Help Needed] Webtty vs SSH for IOT Nodes connected through a CG-NAT
- Azure pipelines truncates connection data HOT 1
- Help Needed - Web-Client Always Throws Error "Function Import Requires a Callable" HOT 2
- Webclient connect disconnected
- Onmessage has not been set for Datachannel data 0 ERROR HOT 2
- Google STUN server HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webtty.