Building sqlite/sqlx features implicitly enables runtimes about axum-login HOT 10 CLOSED

I'm using openidconnect with axum-sessions and found I didn't need axum-login anymore 😄

from axum-login.

That sounds like a pain, sorry you're running into this.

I'm happy to make that optional assuming that's feasible with the right set of feature flags.

from axum-login.

I figured out later that changing sqlx features in my project from runtime-native-rustls to runtime-tokio-rustls sorted it for now, which is probably smarter, but it's likely an issue either way for adoption 😃

from axum-login.

@yaleman if we remove the flag entirely, does that address the issue?

diff --git a/Cargo.toml b/Cargo.toml
index 25f3b09..7c233b5 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -25,7 +25,6 @@ mssql = ["sqlx/mssql"]
 mysql = ["sqlx/mysql"]
 postgres = ["sqlx/postgres"]
 sqlite = ["sqlx/sqlite"]
-sqlx = ["sqlx/runtime-tokio-rustls"]
 
 [dependencies]
 async-trait = "0.1.57"

Applications will need to specify the runtime (which must be tokio) and TLS preference.

from axum-login.

I'm no longer using this crate in the project so I'm not able to test, sorry!

from axum-login.

@yaleman got it. Any particular feedback re moving away from this crate?

from axum-login.

Makes sense!

from axum-login.

There's some work to address this in #44 but I think we need to resolve #73 before we can figure out the best approach here.

from axum-login.

This should be addressed by the new design in #104.

from axum-login.

This is addressed in v0.7.0.

from axum-login.