Comments (3)
Ok just found the solution thank you!!! 😄
from share-this.
Maybe a min length
param could be added?
An other case where it happen (space between two worlds):
from share-this.
In the first case, the selection seems to be empty, but it actually embraces some white spaces, so it's not "collapsed", using the jargon from the Selection API and so it has a right to be "shared" (I won't preclude this possibility).
If you don't want the popover to appear when the selection is made of just white spaces, I suggest to add an active
method to your sharers that returns false
when the selection is made of only white spaces. For example:
active(text, rawText) {
return /\S/.test(rawText);
}
// or, if you're using the default transformer:
active(test) {
return !!text;
}
from share-this.
Related Issues (20)
- How to change append selector? HOT 1
- Source map support HOT 1
- LinkedIn not pulling in data HOT 2
- Cannot read property 'getSelection' of undefined when unmounting React component HOT 1
- Latest release(1.3.0) is a breaking change. HOT 2
- Library name change HOT 3
- Move the sharers to seperate packages
- More control over where the popup appears
- whatsapp HOT 1
- controlling when not to pop
- Popover text not showing
- Disabling this as a user HOT 1
- The ES module points to non-transpiled src/core.js file HOT 2
- cannot change the background color of the popup HOT 5
- Sharers not available in window object
- Facebook sharer error HOT 2
- Translate HOT 3
- Does not work properly on iPhone HOT 5
- controlling when to pop and when not ( based on selected text char length ) HOT 2
- need help
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from share-this.