Giter Club home page Giter Club logo

Comments (3)

jimblue avatar jimblue commented on May 19, 2024 1

Ok just found the solution thank you!!! 😄

from share-this.

jimblue avatar jimblue commented on May 19, 2024

Maybe a min length param could be added?

An other case where it happen (space between two worlds):
screen shot 2017-12-30 at 11 32 18

from share-this.

MaxArt2501 avatar MaxArt2501 commented on May 19, 2024

In the first case, the selection seems to be empty, but it actually embraces some white spaces, so it's not "collapsed", using the jargon from the Selection API and so it has a right to be "shared" (I won't preclude this possibility).

If you don't want the popover to appear when the selection is made of just white spaces, I suggest to add an active method to your sharers that returns false when the selection is made of only white spaces. For example:

active(text, rawText) {
  return /\S/.test(rawText);
}
// or, if you're using the default transformer:
active(test) {
  return !!text;
}

from share-this.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.