Giter Club home page Giter Club logo

Comments (3)

krobelus avatar krobelus commented on June 9, 2024 1

Makes a lot of sense. If I run

kak src/terminal_ui.cc -e 'exec "/4 : 2<ret>"; git blame-jump'

I get an uninteresting change

-    const auto max_content_width = max_size.column - (framed ? 4 : 2) - (assisted ? m_assistant[0].column_length() : 0);
+    const auto max_content_width = (m_info_max_width > 0 ? std::min(max_size.column, m_info_max_width) : max_size.column) -
+                                   (framed ? 4 : 2) -
+                                   (assisted ? m_assistant[0].column_length() : 0);

running another git blame-jump on the deleted line, I get another
uninteresting commit, which only moved this line:

+    const auto max_content_width = max_size.column - (framed ? 4 : 2) - (assisted ? m_assistant[0].column_length() : 0);
 ...
-    const auto content_width = size.column - (framed ? 4 : 2) - (assisted ? m_assistant[0].column_length() : 0);

blaming the deleted line again, I get 34f48cc (Rework ncurses info display,
crop content when overlflowing, 2019-11-24) which added

+    const auto content_width = size.column - (framed ? 4 : 2) - (assisted ? m_assistant[0].column_length() : 0);

Since it's talking about overflowing, I tried an info -style above
command that overflows and it has the same bug; it fails to fill the last
two remaining columns - but that works fine when using a framed info box.

So there seems to be no reason for the current behavior, the fix sounds good.

from kakoune.

krobelus avatar krobelus commented on June 9, 2024 1

from kakoune.

ftonneau avatar ftonneau commented on June 9, 2024

Thanks -- can you take charge of replacing 2 by 0 on line 1314, or should I submit a pull request?

from kakoune.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.