Base class construction in Wren script leaks destructor calls from derived class about wrenbind17 HOT 4 CLOSED

Thanks for the fast reply and for the commit!

from wrenbind17.

There seems to be a bug. Thank you for spotting it.

The destructor (in Wren's terms a finalize allocator) is not called unless some .ctor<>() is was added to the class.

Fixed by always adding finalize to the Wren allocator (commit here: a864db3)

Also added a unit test to verify that it works as it should, based on your example (commit here: 4ae1512)

It should be fixed now. Let me know if the latest master works for you.

I believe always adding finalize to all classes should be fine. Even if the class, for any reason, has a non-public destructor, passing it as a raw pointer to Wren would wrap it in a shared_ptr with no destructor. The shared_ptr would be destructed, not the instance behind the pointer itself.

from wrenbind17.

I can confirm it is working correctly on my side.

from wrenbind17.

Awesome. Thank you for letting me know.

from wrenbind17.