When I exceed my connection rate with a client, I see the following response stanza be

If you can reproduce this, Could you please try this? <div class="highlight highli

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

"auth failure: text" about go-xmpp HOT 5 CLOSED

mattn commented on July 28, 2024

"auth failure: text"

from go-xmpp.

Comments (5)

mattn commented on July 28, 2024

If you can reproduce this, Could you please try this?

diff --git a/xmpp.go b/xmpp.go
index e20b57a..04d377c 100644
--- a/xmpp.go
+++ b/xmpp.go
@@ -406,7 +406,7 @@ func (c *Client) init(o *Options) error {
 	case *saslFailure:
 		// v.Any is type of sub-element in failure,
 		// which gives a description of what failed.
-		return errors.New("auth failure: " + v.Any.Local)
+		return errors.New("auth failure: " + v.Text)
 	default:
 		return errors.New("expected <success> or <failure>, got <" + name.Local + "> in " + name.Space)
 	}
@@ -698,7 +698,8 @@ type saslSuccess struct {
 
 type saslFailure struct {
 	XMLName xml.Name `xml:"urn:ietf:params:xml:ns:xmpp-sasl failure"`
-	Any     xml.Name `xml:",any"`
+	Any     xml.Name
+	Text    string
 }
 
 // RFC 3920  C.5  Resource binding name space

from go-xmpp.

froodian commented on July 28, 2024

Hi @mattn, thanks for the quick response! The diff you provided didn't quite work for me, but this does work (added xml:"text" for it to correctly find the text element, and did a fallback to v.Any.Local if that doesn't exist, so that auth-failure messages still get returned properly)

diff --git a/xmpp.go b/xmpp.go
index e20b57a..04d377c 100644
--- a/xmpp.go
+++ b/xmpp.go
@@ -406,7 +406,7 @@ func (c *Client) init(o *Options) error {
 	case *saslFailure:
+		errorMessage := v.Text
+		if errorMessage == "" {
			// v.Any is type of sub-element in failure,
-			// which gives a description of what failed.
+			// which gives a description of what failed if there was no text element
+			errorMessage = v.Any.Local
+		}
-		return errors.New("auth failure: " + v.Any.Local)
+		return errors.New("auth failure: " + errorMessage)
 	default:
 		return errors.New("expected <success> or <failure>, got <" + name.Local + "> in " + name.Space)
 	}
@@ -698,7 +698,8 @@ type saslSuccess struct {
 
 type saslFailure struct {
 	XMLName xml.Name `xml:"urn:ietf:params:xml:ns:xmpp-sasl failure"`
	Any     xml.Name `xml:",any"`
+	Text    string   `xml:"text"`
 }
 
 // RFC 3920  C.5  Resource binding name space