Giter Club home page Giter Club logo

Comments (4)

nbering avatar nbering commented on May 24, 2024 1

@Ederagp I'm following up here because you mentioned this issue on Gitter and I'd like to help if I can. I am not a maintainer of this project, but I follow the channel because I used it once-upon-a-time and like to use the understanding I gained of the project be using it to help others.

I think the warning is pretty explanatory. Events can't end before they start. In the case of this library, it uses the start and end to position elements on the calendar view, and if they end before they start, it probably ends up with negative height calculations.

You ask, Why not change the start and end date if they're wrong?

As a library author myself, I wouldn't change people's input values either. It leads to bugs that are hard to track down because the library is handling your mistake by fixing it, instead of showing you that you made a mistake. In angular, if you mutate the input value and it is being watched, it can also lead to unwanted extra digest cycles which hurt performance. If the library changed them, and then you changed them back for some reason, it could even end up as an infinite digest loop.

Your best course of action would be to correct your code so that events do not end before they start. This is not a bug.

from angular-bootstrap-calendar.

Ederagp avatar Ederagp commented on May 24, 2024

@nbering Thank you for helping.

How could you know that an event does not end before you start?
in the plunker example the events are correct and I can not visualize the detail

from angular-bootstrap-calendar.

nbering avatar nbering commented on May 24, 2024

Error Output

This warning from your plunker example shows that the event starts at 9am and ends at 1am of the same date. The end time is 8 hours before the start time.

from angular-bootstrap-calendar.

Ederagp avatar Ederagp commented on May 24, 2024

Great, I've modified the time format and it works perfect.

thank you very much @nbering

from angular-bootstrap-calendar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.