Broken on v0.11.0 about longjohn HOT 3 CLOSED

It looks like longjohn's format_stack function never gets called, leaving the stack in a bad state. As for why its not getting called, this code (from prepareStackTrace) :

if error.__previous__?
  previous_stack = error.__previous__.stack
  if previous_stack?.length > 0
    error.__cached_trace__.push(create_callsite(exports.empty_frame))
    error.__cached_trace__.push(previous_stack...)

fails to take into account the case when previous_stack is a string, not an array. The failure leads to a TypeError: Function.prototype.apply: Arguments list has wrong type exception, preventing longjohn from running format_stack.

I was going to make a pull request with the fix, but right out of the box there are 5 test failures, so I am hesitant to touch anything at this point. If some of these errors get resolved, then I will make a request.

from longjohn.

Any news on this issue (or the PR?). I'm having the same problem and I'm sure I'm not the only one ;) It would be great if we could manage to get a PR (without failing tests ;)) merged into the project.

from longjohn.

Fixed by PR.

from longjohn.