Comments (2)
Possibly related: I think there's something seriously wrong with reporting the result. Few days back, I was debugging push notifications suddenly not getting delivered even though I was getting the .success
result. Turns out they were never accepted by APNS servers due to a typo that occurred in the private or public key, can't remember which one. At any rate, neither this case or the one originally reported definitely shouldn't end up with a .success
result case.
For the record, I'm using the new HTTP/2 method of connecting to APNS (just with private and public key manually extracted from the p8 file, to be able to supply it as two environmental variables), if that changes anything.
from vapor-apns.
I just found the cause of the bug, will try to fix it when I have time.
if responseData != "" {
// Get JSON from loaded data string
let jsonNode = JSON(.bytes(responseData.makeBytes()), in: nil).makeNode(in: nil)
if let reason = jsonNode["reason"]?.string {
result = Result.error(apnsId: message.messageId, deviceToken: deviceToken, error: APNSError.init(errorReason: reason))
} else {
result = Result.success(apnsId: message.messageId, deviceToken: deviceToken, serviceStatus: .success)
}
} else {
result = Result.success(apnsId: message.messageId, deviceToken: deviceToken, serviceStatus: .success)
}
Here, the response can't be parsed and jsonNode["reason"]
is nil, so the result is always success.
Edit: Just realized that #50 fixes the problem.
from vapor-apns.
Related Issues (20)
- Linker (?) warning HOT 3
- Fails to find brew HOT 13
- fatal error: unexpectedly found nil while unwrapping an Optional value HOT 3
- Vapor 2.0 HOT 4
- cURL HTTP/2 installer doesn't work in Xcode HOT 1
- silent remote notification doesn't work HOT 1
- Run without Vapor
- Memory increasing after each notification HOT 6
- Its not correctly reporting results HOT 1
- APNs response 'TooManyProviderTokenUpdates' HOT 9
- Which keypath need to Heroku? HOT 1
- Accessing vaporAPNS instance throughout a project
- content-available
- Swift 4 Version HOT 1
- Unable to generate Xcode project HOT 3
- Crashes on Heroku HOT 1
- Support Vapor3? HOT 3
- Does this work with Vapor 3? HOT 1
- Why use curl and not URLSession?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vapor-apns.