toJSON() improvement about jsoncodable HOT 3 OPEN

What do you think about calling super and then making the change for one property? Debatably it's less efficient but Swift doesn't have optional protocol methods so we would have to implement mapPropertyName if we don't need it?

from jsoncodable.

true, there is no optional methods, but you can define a default implementation via protocol extension, achieving the same result. What do you think?

from jsoncodable.

Swift sort of has optional protocol methods by creating default implementations in an extension.

For this example, you could change the protocol to:

public protocol JSONEncodable {
    func toJSON() throws -> AnyObject
    func mapPropertyName(name: String) -> String?
}

And add a default implementation:

public extension JSONEncodable {
    func mapPropertyName(name: String) -> String? {
        return nil
    }
}

Then in toJSON, you write: let label = mapPropertyName(defaultLabel) ?? defaultLabel
Users can optionally override the default implementation of mapPropertyName.

Although to be honest, I'm not a fan of writing writing logic in strings. I much prefer creating to separate models, a JSON model and a domain model, where the actual mapping is done in compile-time checked Swift code. So I don't think I would ever use "mapPropertyName", but it is something you could provide using extensions on protocols.

from jsoncodable.