Comments (8)
Hi @Sajjon you have to fork this repo first and then push to your repo, then you have to make a pull request, feel free to use the button on the top of the github page of your repo
from awesome-swift.
@matteocrippa thanks for your quick reply, sorry for missing that, but maybe we can add that info to the Contributing guide?
I can add that you need to fork as part of my PR in
https://github.com/matteocrippa/awesome-swift/blob/master/.github/CONTRIBUTING.md
How does that sound?
from awesome-swift.
Also might I suggest that everyone runs convert.rb script in order to generate the README.md and preview how it will look before making a PR?
I had to copy the convert.rb script from the .github folder to the root in order to run it. Using Sublime Text and the package Markdown preview and then previewed how it looks. Of course the copy of_ convert.rb_ should not be added to git. Maybe the path of the CONTENTS variable should be changed, so that it can be run from .github folder?
CONTENTS = 'contents.json'
changed to:
CONTENTS = '../contents.json'
Should I add this to the CONTRIBUTING.md too (apart from mentioning that you have to fork)?
from awesome-swift.
Here is a PR #619 with the mentioning of fork in the CONTRIBUTING.md file, and also the Swift project I wanted to add.
from awesome-swift.
What should I do to get the PR #619 approved and merged? :)
from awesome-swift.
@Sajjon I checked the repo, prob it's out of scope from this list, but @dkhamsing has a list of awesome open source apps, prob that repo best fit
from awesome-swift.
@matteocrippa Thanks for your reply... However, I don't really understand why it is out of scope but practice-swift, learn-swift (updated 2 years ago...) is not?
My repo together with those two and others are repos with tutorials to learn swift. Many of the repos in the Third Party Guides list contain repos with small snippets that don't actually give you an understanding of how to build a "full app". My repo aims to give you an understanding of the full chain of creating an app, with GUI, data fetching (HTTP request best practices using generics), JSON parsing, protocol driven design. When to use structs, when to use classes. Building GUI using UIStoryboard as well as Xib.
I have also worked a with readability, all classes < 100 lines of code (except one, having less than 200, and it is one of the tasks to make that smaller).
Apart from that I have worked a lot with the tasks, to make them relevant, easy to understand, in an ascending order of complexity and fun.
Do you still don't think my repo is as good (or better) as other repos in the Third party guides list?
from awesome-swift.
Closing, thanks
from awesome-swift.
Related Issues (20)
- Link Issue
- Update CI HOT 7
- iOS app empty HOT 1
- iOS application HOT 1
- Remove `PySwiftyRegex`
- iOS Framework
- Does this qualify?
- Remove broken link HOT 5
- Add SVG category
- Remove Swift Developments
- The Swift Web Developers link now redirects to spam HOT 1
- Fix link issues
- swift
- Add a network framework HOT 1
- Open Source Updates for Swift Projects - links yields error because Revue is shutdown HOT 1
- Swift Weekly Brief - A multi author curated newsletter - is dead and not getting updated HOT 1
- Is it still supported? HOT 1
- Update Links
- Fix readme header HOT 1
- 💡 Add this project to awesome-italia-opensource
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awesome-swift.