Giter Club home page Giter Club logo

Comments (8)

Sorunome avatar Sorunome commented on August 21, 2024

hmmm unfortunately our linting requires interfaces to be prefixed with I and, well, that would break compability with programs. Not sure what the best approach is here :/

from matrix-discord-parser.

dylhack avatar dylhack commented on August 21, 2024

I gone through and re-factored the usage of DiscordMessageParserResult as well as removing unused imports, variables, and a couple cleanups. See the following fork, it has yet to be tested.

from matrix-discord-parser.

dylhack avatar dylhack commented on August 21, 2024

I've done it at this commit

from matrix-discord-parser.

Sorunome avatar Sorunome commented on August 21, 2024

If you want to contribute, please make a PR :)

Also, it is always a good idea to discuss refactoring things with the maintainers beforehand, a lot of changes in your branch aren't changes soru'd want to see here, unfortunately.

from matrix-discord-parser.

dylhack avatar dylhack commented on August 21, 2024

All the refactors bind by the TSLint rules and all changes were minimal I double checked all the function signatures to make sure nothing was broken.

from matrix-discord-parser.

dylhack avatar dylhack commented on August 21, 2024

Also maybe provide a Matrix room for discussions.

from matrix-discord-parser.

Sorunome avatar Sorunome commented on August 21, 2024

#discord:half-shot.uk

from matrix-discord-parser.

Sorunome avatar Sorunome commented on August 21, 2024

Fixed in #5

from matrix-discord-parser.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.