Last packet ID: None Unhandled Error Traceback (most recent call last): Fi

exceptions.KeyError: 1718838374 about cuwo HOT 3 CLOSED

matpow2 commented on August 20, 2024

exceptions.KeyError: 1718838374

from cuwo.

Comments (3)

Jakky89 commented on August 20, 2024

I think its the PacketHandler in packet.py. Rewriting it could help. This is what I have done now (not tested). Would be great if someone could make suggestions how to make it better:

    def feed(self, data):
        try:
            self.data += data
            reader = ByteReader(self.data)
            while True:
                pos = reader.tell()
                if pos >= len(self.data):
                    break
                packet = read_packet(reader, self.table)
                self.last_packet_id = packet.packet_id
                self.callback(packet)
            self.data = self.data[pos:]
        except (OutOfData, KeyError):
            pass

For comparisation here is the old source (looks buggy and unperformant because also the try is used within a while loop):

    def feed(self, data):
        self.data += data
        reader = ByteReader(self.data)
        while True:
            pos = reader.tell()
            if pos >= len(self.data):
                break
            try:
                packet = read_packet(reader, self.table)
            except OutOfData:
                break
            except KeyError, e:
                print 'Last packet ID:', self.last_packet_id
                raise e
            self.last_packet_id = packet.packet_id
            self.callback(packet)
        self.data = self.data[pos:]

from cuwo.

matpow2 commented on August 20, 2024

No - that's not how it works. What you have provided above will break the framing.
Also, this is a duplicate of #25

from cuwo.

Jakky89 commented on August 20, 2024

Why it should not work with my code change?

from cuwo.

Recommend Projects