Giter Club home page Giter Club logo

Comments (6)

MatthieuDartiailh avatar MatthieuDartiailh commented on June 14, 2024 1

As long as a setup.py was present editable install worked with setuptools 61.2.

I did the change for a couple of project I maintain so I though I could offer to do the same here. I will see how it can work with the fiddling needed for that package though.

from mplcairo.

anntzer avatar anntzer commented on June 14, 2024

Sorry for the lack of wheels, I'll make a new release. Most features of mplcairo have still not been moved to matplotlib itself and there are therefore still benefits in using this library (I believe the comparison in the readme should be up to date).
I don't think PEP517 has anything to do with the build problem; rather, the issue is the one at https://github.com/matplotlib/mplcairo#windows: the paths to the cairo and freetype headers and dlls need to be manually specified, as there is no way I can guess where they are available on your system. Instead, use tools/build-windows-wheel.py to build the wheel. (I could consider moving all that logic into setup.py, together with (e.g.) getting freetype.dll from freetype-py instead of having to download it separately, though.)

from mplcairo.

MatthieuDartiailh avatar MatthieuDartiailh commented on June 14, 2024

Thanks for your answer. Let me know if I can help with anything.

from mplcairo.

anntzer avatar anntzer commented on June 14, 2024

mplcairo 0.5 is now on PyPI.
If you want to make things cleaner, you could try moving most of the logic of build_windows_wheel.py into setup.py (together with adding a dependency on freetype-py and getting freetype.dll from them as well, and getting rid of CL/LIBPATH tricks in favor of ext.include_dirs/ext.library_dirs), which would make building on Windows by the normal command invocations work.

from mplcairo.

MatthieuDartiailh avatar MatthieuDartiailh commented on June 14, 2024

I could try to have a look. Would you interested in also making the repo PEP517 compliant ?

from mplcairo.

anntzer avatar anntzer commented on June 14, 2024

Support for editable installs is extremely important for me, and AFAIK PEP517 and editable installs were incompatible until the release of setuptools 64 (a week ago). Now I guess I would be open to moving to a PEP517-type setup, although I have no experience with that and don't really know how it would look like. However, most of the setup logic would likely still remain dynamic (I guess?), so it's not really clear to me what would be the benefits of such a change.

from mplcairo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.