wmsimage not supporting wms version about basemap HOT 3 OPEN

Hi, @carlosloslas! Thanks for the feedback. Is the patch wms = WebMapService(server, version=kwargs['version']) working as expected in your basemap installation? If so, it should be easy to correct in the repo. For the library patch, I would replace kwargs['version'] with something like kwargs.get('version', None) or an appropriate default version value, since we also need to consider the case in which no version is provided, as before.

from basemap.

Hi,
the bbox arg might be impacted too. I'm working on that too. I'll let you know if I manage to make it work.
My bad, I needed another coffee.

kwargs.get('version', None) won't work as it will pass None instead of a valid version value (which is mandatory).
I suggest to manage all constructors parameters for WebMapService like this:

        wmsInitKeys = ['version', 'xml', 'username', 'password','parse_remote_metadata', 'timeout', 'headers', 'auth']
        wms_options = {k:kwargs[v] for k in wmsInitKeys if k in kwargs}
        kwargs = {k:kwargs[v] for k in kwargs if k not in wmsInitKeys}
        wms = WebMapService(server, **wms_options)

from basemap.

Hi @molinav, thanks for the reply. I'm not running a dev version of the package, so I can't say for sure. I've been working with OWSLib all day and I'm very confident it will.

For a simple patch kwargs.get('version', '1.1.1') would be better since this is the default setting in the OWSLib. As you can see from my error trace, the wms111 refers to the version 1.1.1.

I would happily do some testing, but I've never contributed to a open source package and would need some guidance.

from basemap.