Resizing a panel sometimes gets stuck dragging forever about dockview HOT 5 CLOSED

Awesome, thanks for the quick turnaround! Was really excited about using this library caus it's great. Glad the solution didn't end up being too complicated.

from dockview.

Good news! I think I found a workaround. I noticed when getting stuck in drag mode, I could see the title of one of the panels very faintly, moving around with the mouse:

This made me think the entire panel element was being dragged. I added the following CSS rule and have been unable to recreate the bug since. Note that both selectors seem to be required, otherwise it occasionally reproduces, so I guess both of these elements are sometimes getting selected.

.split-view-container .view-container .view, .groupview {
  user-select: none;
}

from dockview.

Realized that the previous CSS rule was breaking all text selection inside the panel, which is obviously not ideal. Worse, re-enabling user-select: auto on any child element seemed to break the whole thing and the bug came back. Finally I figured out that it just needs to be applied to the drag handles themselves:

.split-view-container .sash-container .sash {
  user-select: none;
  -webkit-user-select: none; /* Safari */
  -moz-user-select: none; /* Firefox */
  -ms-user-select: none; /* IE 10 and IE 11 */
}

This appears to fix the bug as well as preserve normal selection of panel content.

from dockview.

Thanks for the detailed description and the attempt to fix it too!

I just checked this out by adding a global drag listener to check what was actually being dragged here, something like:

document.addEventListener('dragStart', (e) => {
    console.log('drag', e)
});

and yes it seems that the sash element is unintentionally entering a drag state occasionally as below. I think your analysis and fix is correct, great spot.

I will double-check a few things and aim to merge your PR and publish a fix version for this in the next day or two.

Thanks for finding the bug and the fix🙂

from dockview.

This is now merged and published as v1.7.2

from dockview.