Giter Club home page Giter Club logo

Comments (7)

mathieudutour avatar mathieudutour commented on July 24, 2024 2

That makes sense to me 👍

We can discuss the implementation details in the PR

from github-tag-action.

jeremybdk avatar jeremybdk commented on July 24, 2024 1

@koiralakiran1 Sorry I missed that part, where I needed to include the changelog section, again thank you very much for your work!

from github-tag-action.

jeremybdk avatar jeremybdk commented on July 24, 2024

That would definitely solve my issue, and would be great to be able to have more sections by default!

from github-tag-action.

koiralakiran1 avatar koiralakiran1 commented on July 24, 2024

That would definitely solve my issue, and would be great to be able to have more sections by default!

@jeremybdk,
For now, I've only included the sections used by angular to preserve the existing behavior.

@mathieudutour Any comment?

from github-tag-action.

jeremybdk avatar jeremybdk commented on July 24, 2024

Actually there might be an issue, unless I'm missing something obvious that I don't see.

I'm using this repo to test the new version, but it's not working: https://github.com/jeremybdk/test-bump @koiralakiran1 I copied your workflow action, but I cannot find the issue, the changelog is still empty. Any Idea ?

It's working with feat but still not with chore ...

from github-tag-action.

koiralakiran1 avatar koiralakiran1 commented on July 24, 2024

@jeremybdk
Chore/chore is not a default rule or section mentioned in Angular's default rules. So you'll have to include a changelog section in your custom rule explicitly.

i.e. chore:patch:Chores where the last part is the section title in the changelog.

I didn't add additional rules in my PR to mock the previous behavior of the action which used Angular's default rules.

from github-tag-action.

tomavic avatar tomavic commented on July 24, 2024

Do you know how to add the conventionalcommit preset in the commitanalyzer too?

This working example here just using a releaserules semantic-release/release-notes-generator#153 (comment)

from github-tag-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.