Comments (13)
@mathieudutour This is a followup comment for #52 (comment)
Instead of creating a new issue, I thought I'll just comment here.
I think there's something breaking in the latest version. I've tried everything to get it to bump the non-default (for me, patch) version but it doesn't work. I don't have any existing releases / tags.
I pushed to branch live-test
with commit git commit -m "feat: test commit"
I thought it would bump the minor
version but it still bumps the patch
version.
from github-tag-action.
it'd be useful if you could link to your repo where the workflow is failing. It's working fine on mine: https://github.com/mathieudutour/test-bump/releases
from github-tag-action.
Hey @mathieudutour what about commit with "chore(test_chore): Add to Changelog" ? that's mainly my issue, but my repo is private.
from github-tag-action.
I ended up forking your repo and recreating my issue: https://github.com/jeremybdk/test-bump
You can see that chore will not be included in the changelog,
Thanks
from github-tag-action.
Seems like it doesn't work correctly on a branch except for the repo's default branch (not sure if it's the expected behavior):
https://github.com/koiralakiran1/test-bump/runs/1666433143
I created a test branch main-test
from main
(i.e default branch) and included it in release_branches
and pushed a similar (feat
) commit as I pushed in main
. It bumped the minor in main
but still bumps the patch
in main-test
.
from github-tag-action.
ah interesting. It might be because of this: https://github.com/mathieudutour/github-tag-action/blob/master/src/github.ts#L33. I think we should get the sha of head of the branch you're on
from github-tag-action.
ah interesting. It might be because of this: https://github.com/mathieudutour/github-tag-action/blob/master/src/github.ts#L33. I think we should get the sha of head of the branch you're on
Glad to know that what I suspected was right. I was just looking into the code the other day :)
But what I'm confused about is since I branched off main-test
from main
, shouldn't it still have the same commit difference than the one while commiting on the same branch?
from github-tag-action.
Hello @mathieudutour sorry to keep bothering you.
Any plan to fix the chore issue that prevents chore commits to be included in the changelog?
It was also referenced here #17 and was tagged as fixed but it seems that it's still broken.
Thank you so much
from github-tag-action.
I don't have time to work on this sorry, but I'm happy to review a PR
from github-tag-action.
I don't have time to work on this sorry, but I'm happy to review a PR
Thanks will try my best :)
from github-tag-action.
Hello @koiralakiran1,
Is this suppose to fix my original issue here or only the one you raised?
Thanks
from github-tag-action.
Hi @jeremybdk,
I'm extremely sorry that I closed this issue without taking into consideration the original issue that you raised. The changes I made are only going to fix the issue that I raised in the comment above. I just tested the latest version and your issue still persists.
Investigating your issue, I see that the custom_release_rules
that we pass to the action is only used for bumping the version but never used to generate the changelog. I think somehow we should pass this information as an appropriate config to generateNotes
on line 149 below:
github-tag-action/src/action.ts
Lines 148 to 149 in 5961cf9
(which comes from release-notes-generator)
An alternative approach would be to allow configuring both release-notes-generator
& commit-analyzer
using semantic rule configuration file and passing these appropriate configs to generateNotes
but I'm currently not sure how to go about doing these changes to make it work.
Thanks
from github-tag-action.
@jeremybdk I"ve created a new issue to follow up on your original issue and discuss the fix. :)
from github-tag-action.
Related Issues (20)
- Prerelease does not Respect Default_Bump
- Github action suddenly no longer working HOT 1
- [Bug] new_version/new_tag is never undefined HOT 2
- Release tags are created on pull requests despite having set a release_branch HOT 6
- The `set-output` command is deprecated and will be disabled soon. HOT 2
- [Question] how to use custom release rules for AB# HOT 2
- "perf: commit" does not get identified as a Major release but a Patch version HOT 1
- Question - Possible to omit branch name? HOT 2
- Deprecation warning: set-output to be disabled on May 31st, 2023 HOT 2
- on PR getting Error: Not Found HOT 4
- How to fix `Parameter token or opts.auth is required` HOT 3
- [HELP] [QUESTION] Pull request not generate changelog HOT 1
- Bug: default_bump not respected + unwanted text added to tag HOT 5
- Access latest "release" version?
- Suggestion - Use github.token HOT 1
- Possibility to customise issueUrlFormat
- how to force push an existed tag ?
- [feature] Rolling release versions
- Set Major. Minor, or Patch Release HOT 2
- Bug: Unable to retrieve commits history when using Squash and Merge on Pull requests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-tag-action.