Chore still not included in changelog about github-tag-action HOT 13 CLOSED

@mathieudutour This is a followup comment for #52 (comment)

Instead of creating a new issue, I thought I'll just comment here.
I think there's something breaking in the latest version. I've tried everything to get it to bump the non-default (for me, patch) version but it doesn't work. I don't have any existing releases / tags.

Here's my workflow:

I pushed to branch live-test with commit git commit -m "feat: test commit"

I thought it would bump the minor version but it still bumps the patch version.

from github-tag-action.

it'd be useful if you could link to your repo where the workflow is failing. It's working fine on mine: https://github.com/mathieudutour/test-bump/releases

from github-tag-action.

Hey @mathieudutour what about commit with "chore(test_chore): Add to Changelog" ? that's mainly my issue, but my repo is private.

from github-tag-action.

I ended up forking your repo and recreating my issue: https://github.com/jeremybdk/test-bump
You can see that chore will not be included in the changelog,

Thanks

from github-tag-action.

Seems like it doesn't work correctly on a branch except for the repo's default branch (not sure if it's the expected behavior):
https://github.com/koiralakiran1/test-bump/runs/1666433143

I created a test branch main-test from main (i.e default branch) and included it in release_branches and pushed a similar (feat) commit as I pushed in main. It bumped the minor in main but still bumps the patch in main-test.

from github-tag-action.

ah interesting. It might be because of this: https://github.com/mathieudutour/github-tag-action/blob/master/src/github.ts#L33. I think we should get the sha of head of the branch you're on

from github-tag-action.

ah interesting. It might be because of this: https://github.com/mathieudutour/github-tag-action/blob/master/src/github.ts#L33. I think we should get the sha of head of the branch you're on

Glad to know that what I suspected was right. I was just looking into the code the other day :)

But what I'm confused about is since I branched off main-test from main, shouldn't it still have the same commit difference than the one while commiting on the same branch?

from github-tag-action.

Hello @mathieudutour sorry to keep bothering you.
Any plan to fix the chore issue that prevents chore commits to be included in the changelog?
It was also referenced here #17 and was tagged as fixed but it seems that it's still broken.

Thank you so much

from github-tag-action.

I don't have time to work on this sorry, but I'm happy to review a PR

from github-tag-action.

I don't have time to work on this sorry, but I'm happy to review a PR

Thanks will try my best :)

from github-tag-action.

Hello @koiralakiran1,
Is this suppose to fix my original issue here or only the one you raised?

Thanks

from github-tag-action.

Hi @jeremybdk,

I'm extremely sorry that I closed this issue without taking into consideration the original issue that you raised. The changes I made are only going to fix the issue that I raised in the comment above. I just tested the latest version and your issue still persists.

Investigating your issue, I see that the custom_release_rules that we pass to the action is only used for bumping the version but never used to generate the changelog. I think somehow we should pass this information as an appropriate config to generateNotes on line 149 below:

(which comes from release-notes-generator)

An alternative approach would be to allow configuring both release-notes-generator & commit-analyzer using semantic rule configuration file and passing these appropriate configs to generateNotes but I'm currently not sure how to go about doing these changes to make it work.

Thanks

from github-tag-action.

@jeremybdk I"ve created a new issue to follow up on your original issue and discuss the fix. :)

from github-tag-action.